[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5708: vmware: fix cpu reservation during vm scale

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#discussion_r755747038



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1765,7 +1765,7 @@ protected ScaleVmAnswer execute(ScaleVmCommand cmd) {
 
             // Check if license supports the feature
             VmwareHelper.isFeatureLicensed(hyperHost, FeatureKeyConstants.HOTPLUG);
-            VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), vmSpec.getMinSpeed(), (int) requestedMaxMemoryInMb, ramMb,
+            VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(), vmSpec.getMaxSpeed(), getReservedCpuMHZ(vmSpec), (int) requestedMaxMemoryInMb, ramMb,

Review comment:
       yes getReservedCpuMHZ() makes sense, since it will set 0 if VmwareReserveCPU is false which is correct.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org