You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "davidradl (via GitHub)" <gi...@apache.org> on 2024/12/09 13:15:23 UTC
[PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
davidradl opened a new pull request, #25766:
URL: https://github.com/apache/flink/pull/25766
After [https://github.com/apache/flink/pull/25714](https://github.com/apache/flink/pull/25714) the level of google-java-format required changed. The documentation refers to this level in the IDE setup. This is a hotfix to amend the documentation so it refers to the correct version in line with 25714.
I am not in position to update the Chinese version of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25766:
URL: https://github.com/apache/flink/pull/25766#issuecomment-2527909374
@snuyanzin I noticed that there is a reference in the docs to the old google-java-format version; would you be ok to merge this please so it matches your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876026898
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,7 +124,7 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
Review Comment:
@snuyanzin yes - I will do that - accidently added extra files to the commit. I will sort that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876008473
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,13 +124,15 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
and install it as follows. Make sure to never update this plugin.
1. Go to "Settings" → "Plugins".
2. Click the gear icon and select "Install Plugin from Disk".
3. Navigate to the downloaded ZIP file and select it.
+Note for flink v1 the required level of [google-java-format](https://github.com/google/google-java-format) was [google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+
Review Comment:
I don't think we need this
every Flink version has its own branch and for each there is a separate doc page
so for 1.x there are already existing pages covering this
otherwise we will end up with duplicating every change between versions in several places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25766:
URL: https://github.com/apache/flink/pull/25766#issuecomment-2527939194
CI is failing. Looking into that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876023276
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,7 +124,7 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
Review Comment:
shouldn't same done for Chinese version?
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,7 +124,7 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
Review Comment:
shouldn't same be done for Chinese version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876032909
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,7 +124,7 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
Review Comment:
@snuyanzin ready for review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876008473
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,13 +124,15 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
and install it as follows. Make sure to never update this plugin.
1. Go to "Settings" → "Plugins".
2. Click the gear icon and select "Install Plugin from Disk".
3. Navigate to the downloaded ZIP file and select it.
+Note for flink v1 the required level of [google-java-format](https://github.com/google/google-java-format) was [google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+
Review Comment:
I don't think we need this
every Flink version has its own branch and each there is a separate doc page
so for 1.x there are already existing pages covering this
otherwise we will end up with duplicating every change between versions in several places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25766:
URL: https://github.com/apache/flink/pull/25766#issuecomment-2527916543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "025dfb56ca13c371ccaa8627cc43d5fce5cfb8c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "025dfb56ca13c371ccaa8627cc43d5fce5cfb8c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 025dfb56ca13c371ccaa8627cc43d5fce5cfb8c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25766:
URL: https://github.com/apache/flink/pull/25766#issuecomment-2528086022
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #25766:
URL: https://github.com/apache/flink/pull/25766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25766:
URL: https://github.com/apache/flink/pull/25766#discussion_r1876023276
##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -124,7 +124,7 @@ install them, and restart the IDE if prompted:
You will also need to install the [google-java-format](https://github.com/google/google-java-format)
plugin. However, a specific version of this plugin is required. Download
-[google-java-format v1.7.0.6](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/115957)
+[google-java-format v1.24.0.0](https://plugins.jetbrains.com/plugin/8527-google-java-format/versions/stable/614263)
Review Comment:
shouldn't same be done for Chinese version?
https://github.com/apache/flink/blob/158786282b1260958cc3e89b3cb8d8a063fa07df/docs/content.zh/docs/flinkDev/ide_setup.md?plain=1#L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [docs] Fix the google-java-format level in docs in line with PR 25714 [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25766:
URL: https://github.com/apache/flink/pull/25766#issuecomment-2528271428
CI is failing - it got past the docs test but then failed to complete the step after - so the job was cancelled. I will try again later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org