You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "ChiaPing Tsai (JIRA)" <ji...@apache.org> on 2016/10/18 01:17:58 UTC

[jira] [Updated] (HBASE-16866) Avoid NPE in AsyncRequestFutureImpl#updateStats

     [ https://issues.apache.org/jira/browse/HBASE-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaPing Tsai updated HBASE-16866:
----------------------------------
    Attachment: HBASE-16866.v0.patch

> Avoid NPE in AsyncRequestFutureImpl#updateStats
> -----------------------------------------------
>
>                 Key: HBASE-16866
>                 URL: https://issues.apache.org/jira/browse/HBASE-16866
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ChiaPing Tsai
>            Priority: Minor
>         Attachments: HBASE-16866.v0.patch
>
>
> If region disables the stats, it won’t response any ClientProtos.RegionLoadStats to client. So the NEP will happen in AsyncRequestFutureImpl#updateStats.
> We should use relevant log instead of NEP because the data manipulation shouldn’t be broken by statistics.
> {noformat}
>   protected void updateStats(ServerName server, Map<byte[], MultiResponse.RegionResult> results) {
>       …
>       ClientProtos.RegionLoadStats stat = regionStats.getValue().getStat();
>       RegionLoadStats regionLoadstats = ProtobufUtil.createRegionLoadStats(stat);
>       …
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)