[GitHub] [pulsar] codelipenghui commented on a change in pull request #12706: clean code style issues

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #12706:
URL: https://github.com/apache/pulsar/pull/12706#discussion_r747132087



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/InterceptorsTest.java
##########
@@ -151,12 +151,12 @@ public void close() {
 
             @Override
             public Message<String> beforeSend(Producer<String> producer, Message<String> message) {
-                throw new NullPointerException();
+                throw new IllegalArgumentException();

Review comment:
       This test is testing the interceptor throws exceptions, so it's ok for any runtime exceptions.

##########
File path: pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/decoder/protobufnative/TestMsg.java
##########
@@ -190,7 +190,7 @@ private SubMessage(
         throws com.google.protobuf.InvalidProtocolBufferException {
       this();
       if (extensionRegistry == null) {
-        throw new java.lang.NullPointerException();
+        throw new java.lang.IllegalArgumentException();

Review comment:
       Looks like the TestMsg is generated by protobuf, we can skip this class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org