You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/03 20:05:11 UTC
[GitHub] [beam] KevinGG opened a new pull request #11032: [BEAM-8335]
Display rather than logging when is_in_notebook.
KevinGG opened a new pull request #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032
1. Added an IPythonLogHandler to display logs as styled HTMLs to
frontends connected to current IPython kernel. The implementation
works with all IPython notebooks.
2. The user can control the logging with native Python logging APIs.
3. The log handler is only registered when current environment is in a
notebook and it only affects module loggers under interactive
package.
4. The log handler is added to a dummy interactive "root" logger and
doesn't change any real logger's default configuration.
Change-Id: Iaec9272e0ee61d091979822680615791f1a57cd6
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595604106
Run PythonFormatter PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] KevinGG commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-594825333
R: @pabloem
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-594836478
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem merged pull request #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595503103
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595504547
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595603902
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595603969
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595503135
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595504514
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595523014
Run PythonFormatter PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595504593
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] KevinGG commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
KevinGG commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-594142836
R: @rohdesamuel
PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11032: [BEAM-8335] Display
rather than logging when is_in_notebook.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11032: [BEAM-8335] Display rather than logging when is_in_notebook.
URL: https://github.com/apache/beam/pull/11032#issuecomment-595612913
thanks Ning!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services