[jira] [Commented] (CALCITE-2112) Add Maven wrapper to Calcite

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608592#comment-16608592 ] 

Julian Hyde commented on CALCITE-2112:
--------------------------------------

I re-opened the discussion on an [email thread|https://lists.apache.org/thread.html/cb4cb317c1773c09dbbc19372d9fac0ded0aadad4ad9ae0bce407756@%3Cdev.calcite.apache.org%3E] and we agreed to do this.

Fixed in [8f43b3b8|http://git-wip-us.apache.org/repos/asf/calcite/commit/8f43b3b8]. (The fix changes [~rdsr]'s PR somewhat: we no longer commit the wrapper jar, [~Sergey Nuyanzin] suggested a change for TLS on Windows, and I modified the documentation.)

> Add Maven wrapper to Calcite
> ----------------------------
>
>                 Key: CALCITE-2112
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2112
>             Project: Calcite
>          Issue Type: Improvement
>          Components: build
>            Reporter: Ratandeep Ratti
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.16.0
>
>
> A Maven wrapper is a nice idea borrowed from Gradle.
> * It makes the project's build fully encapsulated. Users don't have to setup a version of Maven (which could potentially be different than that recommended by Calcite)
> * It also allows Calcite to control the Maven dependency (upgrading to newer versions for example) making it transparent to the user. 
> * Users now will use maven commands as 
> {code}
> ./mvnw clean install
> {code}
> instead
> {code}
> mvn clean install
> {code}
> Presto has done the same -- https://github.com/prestodb/presto/blob/master/mvnw
> It is also extremely easy to setup. See https://github.com/takari/maven-wrapper  . 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)