You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/03/15 15:55:59 UTC

[GitHub] [incubator-livy] Tagar commented on a change in pull request #135: [LIVY-544] Allow interpreterExecutor run in ThreadPool

Tagar commented on a change in pull request #135: [LIVY-544] Allow interpreterExecutor run in ThreadPool
URL: https://github.com/apache/incubator-livy/pull/135#discussion_r266043522
 
 

 ##########
 File path: core/src/main/scala/org/apache/livy/sessions/Kind.scala
 ##########
 @@ -35,6 +35,8 @@ object Shared extends Kind("shared")
 
 object SQL extends Kind("sql")
 
+object ConcurrentSQL extends Kind("concurrentSQL")
 
 Review comment:
   @mgaido91 good point. There was some discussion on this at https://issues.apache.org/jira/browse/LIVY-544
   For code paragraphs chances are that there is a dependency between code items, and they can't run in parallel. For SQL sometimes there is no dependency often when it's just a SELECT.. but we let end-users decide if there is truly no dependency and let queries execute in parallel only when it was requested explicitly. Also this was modeled after Zeppelin to some degree - Zeppelin only allows parallel execution for SQL cells and not code cells like pyspark. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services