[GitHub] mike-tutkowski opened a new pull request #2656: Only perform certain actions here with managed storage if the VM is s…

[GitBox <gi...@apache.org>]

mike-tutkowski opened a new pull request #2656: Only perform certain actions here with managed storage if the VM is s…
URL: https://github.com/apache/cloudstack/pull/2656
 
 
   …tarted up in a new cluster (not if it is just started up on a new host in the same cluster).
   
   ## Description
   Example: A VM that uses managed storage is stopped. The VM is then started on a different host in the same cluster. The Start operation fails.
   
   To get around this issue, you must either start the VM up on the same host or on a host in a different cluster.
   
   The reason is due to a slightly erroneous check in VolumeOrchestrator.prepare.
   
   To solve this issue, we should be checking if the cluster ID changes, not if the host ID changes.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   
   I noticed that I could not start a stopped VM that uses managed storage on a different host in the same cluster as the host it was originally running on.
   
   After I changed the code (this PR), I re-tested the scenario. I can now start the VM up on a different host in the same cluster as the host it was originally running on. Also, I can still start it up on the same host as it was originally running on or on a host in a different cluster.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services