You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2023/02/14 02:18:30 UTC
[GitHub] [shardingsphere] iamhucong opened a new pull request, #24149: Add PluginJarLoaderTest (#23423)
iamhucong opened a new pull request, #24149:
URL: https://github.com/apache/shardingsphere/pull/24149
Fixes #23423.
Changes proposed in this pull request:
- test cases for PluginJarLoaderTest class
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jiangML commented on pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149#issuecomment-1451253573
@iamhucong Hi, already no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin commented on PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149#issuecomment-1430736417
@jiangML Hello, Can you help check this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149#issuecomment-1430605983
@tuichenchuxin Could you help review the code? Please advise me if I have any problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149#issuecomment-1430735275
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24149](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1cd3cd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7d1d1c3cc2bbdd56cb7c245f681fb6666cedaf78?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d1d1c3) will **increase** coverage by `0.02%`.
> The diff coverage is `92.30%`.
> :exclamation: Current head e1cd3cd differs from pull request most recent head 78403cb. Consider uploading reports for the commit 78403cb to get more accurate results
```diff
@@ Coverage Diff @@
## master #24149 +/- ##
============================================
+ Coverage 50.12% 50.14% +0.02%
Complexity 1576 1576
============================================
Files 3259 3258 -1
Lines 53470 53468 -2
Branches 9830 9830
============================================
+ Hits 26801 26812 +11
+ Misses 24308 24293 -15
- Partials 2361 2363 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ysql/authentication/MySQLAuthenticationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2F1dGhlbnRpY2F0aW9uL015U1FMQXV0aGVudGljYXRpb25FbmdpbmUuamF2YQ==) | `92.72% <92.30%> (-1.03%)` | :arrow_down: |
| [...uthenticator/MySQLNativePasswordAuthenticator.java](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2F1dGhlbnRpY2F0aW9uL2F1dGhlbnRpY2F0b3IvTXlTUUxOYXRpdmVQYXNzd29yZEF1dGhlbnRpY2F0b3IuamF2YQ==) | `93.75% <0.00%> (-6.25%)` | :arrow_down: |
| [...gsphere/agent/core/log/slf4j/SLF4JAgentLogger.java](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9sb2cvc2xmNGovU0xGNEpBZ2VudExvZ2dlci5qYXZh) | `25.00% <0.00%> (+25.00%)` | :arrow_up: |
| [...gsphere/agent/core/plugin/jar/PluginJarLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/24149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vamFyL1BsdWdpbkphckxvYWRlci5qYXZh) | `86.66% <0.00%> (+86.66%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jiangML commented on pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149#issuecomment-1441579359
@iamhucong HI, can `plugin0.jar` be an empty jar file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on pull request #24149: Add PluginJarLoaderTest (#23423)
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on PR #24149:
URL: https://github.com/apache/shardingsphere/pull/24149#issuecomment-1443798170
> @iamhucong HI, can `plugin0.jar` be an empty jar file? And can it be named `test-plugin.jar`?
has been modified, please help check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org