You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/20 20:56:51 UTC

[GitHub] [airflow] DMilmont opened a new pull request, #25850: pretty print KubernetesPodOperator rendered template env_vars

DMilmont opened a new pull request, #25850:
URL: https://github.com/apache/airflow/pull/25850

   closes: #24197
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25850:
URL: https://github.com/apache/airflow/pull/25850#issuecomment-1222538909

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] XD-DENG merged pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

Posted by GitBox <gi...@apache.org>.
XD-DENG merged PR #25850:
URL: https://github.com/apache/airflow/pull/25850


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] DMilmont commented on pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

Posted by GitBox <gi...@apache.org>.
DMilmont commented on PR #25850:
URL: https://github.com/apache/airflow/pull/25850#issuecomment-1222502121

   Thank you! This should be good to go now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] XD-DENG commented on pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #25850:
URL: https://github.com/apache/airflow/pull/25850#issuecomment-1222090762

   @DMilmont  mind rebasing your branch please? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] XD-DENG commented on pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #25850:
URL: https://github.com/apache/airflow/pull/25850#issuecomment-1222450676

   Hi @DMilmont , I was trying to do the rebase on your behalf, but eventually I'm not sure if the commit would be attached with my name (which I would like to avoid).
   
   Please do another rebase by yourself and force-push. Afterwards we would be happy to merge this change.
   
   Thanks for the contribution and sorry for the inconvenience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25850: pretty print KubernetesPodOperator rendered template env_vars

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25850:
URL: https://github.com/apache/airflow/pull/25850#issuecomment-1221407250

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org