[jira] [Work logged] (BEAM-5636) Java support for custom dataflow worker jar

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5636?focusedWorklogId=154022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154022 ]

ASF GitHub Bot logged work on BEAM-5636:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/18 20:46
            Start Date: 12/Oct/18 20:46
    Worklog Time Spent: 10m 
      Work Description: herohde commented on a change in pull request #6665: [BEAM-5636] Java support for custom dataflow worker jar
URL: https://github.com/apache/beam/pull/6665#discussion_r224910454
 
 

 ##########
 File path: sdks/java/container/boot.go
 ##########
 @@ -104,6 +104,9 @@ func main() {
 		filepath.Join(jarsDir, "beam-sdks-java-harness.jar"),
 	}
 	for _, md := range artifacts {
+		if strings.HasPrefix(md.Name, "beam-runners-google-cloud-dataflow-java-fn-api-worker") {
 
 Review comment:
   We should only make this check if the experiment is set. Also, the name will change to "dataflow-worker.jar" when the artifact bug is fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 154022)
            Time Spent: 10m
    Remaining Estimate: 0h

> Java support for custom dataflow worker jar
> -------------------------------------------
>
>                 Key: BEAM-5636
>                 URL: https://issues.apache.org/jira/browse/BEAM-5636
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Henning Rohde
>            Assignee: Boyuan Zhang
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> One of the slightly subtle aspects is that we would need to ignore one of the staged jars for portable Java jobs. That requires a change to the Java boot code: https://github.com/apache/beam/blob/66d7c865b7267f388ee60752891a9141fad43774/sdks/java/container/boot.go#L107



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)