You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/02/15 06:22:33 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #77:
Recovery times out if the cluster initially has no nodes
yangwwei opened a new pull request #77: Recovery times out if the cluster initially has no nodes
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77
1. when there is no nodes in the cluster, recovery timesout
2. support KUBECONFIG environment variable for local mode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull
request #77: Recovery times out if the cluster initially has no nodes
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #77: Recovery times out if the cluster initially has no nodes
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77#discussion_r381059628
##########
File path: pkg/cache/context_recovery.go
##########
@@ -205,12 +205,11 @@ func waitAndListPods(lister v1.PodLister) ([]*corev1.Pod, error) {
func waitAndListNodes(lister v1.NodeLister) ([]*corev1.Node, error) {
var allNodes []*corev1.Node
+ var listErr error
err := utils.WaitForCondition(func() bool {
//nolint:errcheck
Review comment:
This lint comment should be removed as we now check the err
why is the declaration of listErr outside of the function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on issue #77:
Recovery times out if the cluster initially has no nodes
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on issue #77: Recovery times out if the cluster initially has no nodes
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77#issuecomment-588569224
With the changes to the code the fix looks good. I'll commit soon.
Just for future reference it would be good to explain where the nil pointer came from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s merged pull request #77:
Recovery times out if the cluster initially has no nodes
Posted by GitBox <gi...@apache.org>.
wilfred-s merged pull request #77: Recovery times out if the cluster initially has no nodes
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull
request #77: Recovery times out if the cluster initially has no nodes
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #77: Recovery times out if the cluster initially has no nodes
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77#discussion_r381106233
##########
File path: pkg/common/resource.go
##########
@@ -159,8 +159,9 @@ func CreateUpdateRequestForNewNode(node Node) si.UpdateRequest {
func CreateUpdateRequestForUpdatedNode(node Node) si.UpdateRequest {
// Currently only includes resource in the update request
nodeInfo := &si.UpdateNodeInfo{
- NodeID: node.name,
- SchedulableResource: node.resource,
+ NodeID: node.name,
+ Attributes: make(map[string]string),
Review comment:
This code has been the same for a long time and is only called within the mock scheduler (test only)
Currently without this change I do not see a nil pointer in the tests.
Please explain how this caused a nil pointer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org