You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2013/04/26 08:29:28 UTC
Review Request: Multiple IP Ranges Support in CloudStack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
Diffs
-----
test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
Diff: https://reviews.apache.org/r/10792/diff/
Testing
-------
Thanks,
sanjeev n
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19842
-----------------------------------------------------------
Ship it!
commit b2fdd5e2a23b44e5976c7135632d1ca6ade57663
Author: sanjeevneelarapu <sa...@citrix.com>
Date: Fri Apr 26 17:10:37 2013 +0530
CLOUDSTACK-702: Tests for Multiple IP Ranges
1. Adding a cidr in existing subnet
2. Adding a cidr in new subnet
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- Prasanna Santhanam
On April 29, 2013, 5:35 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 5:35 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10792/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
-----------------------------------------------------------
(Updated April 29, 2013, 5:35 a.m.)
Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
Changes
-------
Combined three patches into one patch
Description
-------
Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
This addresses bug CLOUDSTACK-702.
Diffs (updated)
-----
test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
Diff: https://reviews.apache.org/r/10792/diff/
Testing
-------
Thanks,
sanjeev n
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
-----------------------------------------------------------
(Updated April 26, 2013, 1:44 p.m.)
Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
Changes
-------
Moved redundant code to methods.
Description
-------
Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
This addresses bug CLOUDSTACK-702.
Diffs (updated)
-----
test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
Diff: https://reviews.apache.org/r/10792/diff/
Testing
-------
Thanks,
sanjeev n
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19766
-----------------------------------------------------------
test/integration/component/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/10792/#comment40775>
If it makes sense to combine the testcases I'd do so. No need to bloat up the testcase numbers. More the tests, longer the run.
But in your case I'd say include a comment explaining how this test differs from your test. Minor nitpick. Else this can be shipped.!
- Prasanna Santhanam
On April 26, 2013, 11 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 11 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10792/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19764
-----------------------------------------------------------
Ship it!
Looks good
- SrikanteswaraRao Talluri
On April 26, 2013, 11 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 11 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
>
>
> Description
> -------
>
> Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
>
>
> This addresses bug CLOUDSTACK-702.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10792/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/
-----------------------------------------------------------
(Updated April 26, 2013, 11 a.m.)
Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
Changes
-------
Modified as per the review comments.
Description
-------
Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
This addresses bug CLOUDSTACK-702.
Diffs (updated)
-----
test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
Diff: https://reviews.apache.org/r/10792/diff/
Testing
-------
Thanks,
sanjeev n
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19754
-----------------------------------------------------------
test/integration/component/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/10792/#comment40762>
i think you can remove this
test/integration/component/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/10792/#comment40759>
remove tags that are not applicable
test/integration/component/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/10792/#comment40760>
remove tags that are not applicable
- SrikanteswaraRao Talluri
On April 26, 2013, 6:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 6:29 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10792/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request: Multiple IP Ranges Support in CloudStack
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10792/#review19763
-----------------------------------------------------------
Sanjeev, along with your patch can you also include the JIRA id of the feature that you are writing tests for?
- Prasanna Santhanam
On April 26, 2013, 6:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10792/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 6:29 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Adding two test cases(Adding guest CIDR in same and diff subnet) for "Multiple IP Ranges" support in CloudStack.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10792/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sanjeev n
>
>