You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 16:12:00 UTC
[GitHub] [spark] wangyum opened a new pull request #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
wangyum opened a new pull request #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056
### What changes were proposed in this pull request?
This PR removed some calls to `requireDbExists` and `requireTableExists` in `InMemoryCatalog` and `HiveExternalCatalog` because we has checked it in `SessionCatalog`.
For e.g.: SessionCatalog.createTable checked `requireDbExists` in
https://github.com/apache/spark/blob/66b4fd040e97cb6de6536a5545017278879c98fb/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala#L318
https://github.com/apache/spark/blob/66b4fd040e97cb6de6536a5545017278879c98fb/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L246
### Why are the changes needed?
Improve `HiveExternalCatalog` performance.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Exist test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606307968
**[Test build #120616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120616/testReport)** for PR 28056 at commit [`bf3ceab`](https://github.com/apache/spark/commit/bf3ceab49486b518e9199f88dd251e83eb018ab9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606369583
**[Test build #120625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120625/testReport)** for PR 28056 at commit [`c0f1305`](https://github.com/apache/spark/commit/c0f1305ed8abf571e226d211a74d6dbd98b55e33).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606308285
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606067748
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120592/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606434886
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120625/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605162339
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120501/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605824828
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605682846
**[Test build #120557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120557/testReport)** for PR 28056 at commit [`729109f`](https://github.com/apache/spark/commit/729109fc4220fe7e23ce96d1b6a251f022ad4ffd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606309121
thanks for removing the deadcode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606434886
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120625/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606434878
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606341643
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120616/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605089796
Could you explain about the performance gain in your environment in the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605091050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25207/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605089796
Could you explain about the performance gain in your environment in the PR description? In general, I prefer to keep the existing code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605824195
**[Test build #120578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120578/testReport)** for PR 28056 at commit [`1e6eaef`](https://github.com/apache/spark/commit/1e6eaefbf6b7529391d9effa98dd37c7386fd556).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606434541
**[Test build #120625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120625/testReport)** for PR 28056 at commit [`c0f1305`](https://github.com/apache/spark/commit/c0f1305ed8abf571e226d211a74d6dbd98b55e33).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606369906
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25327/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606369900
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606308293
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25319/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605162339
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120501/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605091050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25207/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606067733
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605162293
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606341637
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605824842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25282/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605161850
**[Test build #120501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120501/testReport)** for PR 28056 at commit [`729109f`](https://github.com/apache/spark/commit/729109fc4220fe7e23ce96d1b6a251f022ad4ffd).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605824842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25282/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606307552
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605692203
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120557/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605872836
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120578/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606009429
**[Test build #120592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120592/testReport)** for PR 28056 at commit [`bf3ceab`](https://github.com/apache/spark/commit/bf3ceab49486b518e9199f88dd251e83eb018ab9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605162293
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605090290
**[Test build #120501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120501/testReport)** for PR 28056 at commit [`729109f`](https://github.com/apache/spark/commit/729109fc4220fe7e23ce96d1b6a251f022ad4ffd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605089066
cc @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606067733
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606010276
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605872826
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606010290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25295/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605872614
**[Test build #120578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120578/testReport)** for PR 28056 at commit [`1e6eaef`](https://github.com/apache/spark/commit/1e6eaefbf6b7529391d9effa98dd37c7386fd556).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605692200
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606341643
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120616/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605692131
**[Test build #120557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120557/testReport)** for PR 28056 at commit [`729109f`](https://github.com/apache/spark/commit/729109fc4220fe7e23ce96d1b6a251f022ad4ffd).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605872826
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605682846
**[Test build #120557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120557/testReport)** for PR 28056 at commit [`729109f`](https://github.com/apache/spark/commit/729109fc4220fe7e23ce96d1b6a251f022ad4ffd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606308285
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606067748
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120592/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605090290
**[Test build #120501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120501/testReport)** for PR 28056 at commit [`729109f`](https://github.com/apache/spark/commit/729109fc4220fe7e23ce96d1b6a251f022ad4ffd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605681883
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606341505
**[Test build #120616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120616/testReport)** for PR 28056 at commit [`bf3ceab`](https://github.com/apache/spark/commit/bf3ceab49486b518e9199f88dd251e83eb018ab9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605682012
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606010276
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605682012
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605682017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25263/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28056:
[SPARK-31288][SQL] Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#discussion_r400008389
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##########
@@ -234,7 +235,7 @@ case class DropTableCommand(
}
}
- if (isTempView || catalog.tableExists(tableName)) {
+ if (isTempView || isTableExist) {
Review comment:
Hm, @wangyum, when `isTempView` is `true`, `catalog.tableExists(tableName)` won't be called by short-circuiting. So, this isn't a clean improvement but it has trade-off. Can you clarify this trade-off as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606369583
**[Test build #120625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120625/testReport)** for PR 28056 at commit [`c0f1305`](https://github.com/apache/spark/commit/c0f1305ed8abf571e226d211a74d6dbd98b55e33).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606307968
**[Test build #120616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120616/testReport)** for PR 28056 at commit [`bf3ceab`](https://github.com/apache/spark/commit/bf3ceab49486b518e9199f88dd251e83eb018ab9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605682017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25263/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606308293
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25319/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606009429
**[Test build #120592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120592/testReport)** for PR 28056 at commit [`bf3ceab`](https://github.com/apache/spark/commit/bf3ceab49486b518e9199f88dd251e83eb018ab9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606369906
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25327/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605872836
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120578/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
wangyum commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-605829230
Thank you @dongjoon-hyun @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605091044
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606434878
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606010290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25295/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28056: [SPARK-31288][SQL]
Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606341637
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605091044
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605824195
**[Test build #120578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120578/testReport)** for PR 28056 at commit [`1e6eaef`](https://github.com/apache/spark/commit/1e6eaefbf6b7529391d9effa98dd37c7386fd556).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605692200
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605692203
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120557/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28056: [SPARK-31288][SQL] Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#issuecomment-606067424
**[Test build #120592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120592/testReport)** for PR 28056 at commit [`bf3ceab`](https://github.com/apache/spark/commit/bf3ceab49486b518e9199f88dd251e83eb018ab9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Remove `getRawTable` in `alterPartitions`
URL: https://github.com/apache/spark/pull/28056#issuecomment-606369900
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28056:
[SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28056: [SPARK-31288][SQL] Reduce calls to requireDbExists and requireTableExists
URL: https://github.com/apache/spark/pull/28056#issuecomment-605824828
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org