You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/02 13:08:01 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #19811: [CI] Improve GitHub Actions integration test

sandynz opened a new pull request, #19811:
URL: https://github.com/apache/shardingsphere/pull/19811

   
   Changes proposed in this pull request:
   - it.yml, it-transaction.yml, and it-scaling.yml are changed, triggering is limited to dedicated integration test module to reduce un-uncessary triggering
   - Add on push paths for it-transaction.yml
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #19811: [CI] Improve GitHub Actions integration test

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #19811:
URL: https://github.com/apache/shardingsphere/pull/19811#issuecomment-1203359625

   I think it is better to run tests if pom.xml under `shardingsphere-test/` changed. Take https://github.com/apache/shardingsphere/pull/19730 as example, some tests failed when I bump the testcontainers.
   
   - https://github.com/apache/shardingsphere/actions/runs/2771863357
   - https://github.com/apache/shardingsphere/actions/runs/2771987377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #19811: [CI] Improve GitHub Actions integration test

Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #19811:
URL: https://github.com/apache/shardingsphere/pull/19811#issuecomment-1203404432

   > I think it is better to run tests if pom.xml under `shardingsphere-test/` changed. Take #19730 as example, some tests failed when I bump the testcontainers.
   > 
   >     * https://github.com/apache/shardingsphere/actions/runs/2771863357
   > 
   >     * https://github.com/apache/shardingsphere/actions/runs/2771987377
   
   Thanks. I'll add `shardingsphere-test/pom.xml`.
   `shardingsphere-test/**/pom.xml` will trigger two much, e.g. change of `shardingsphere-integration-test-transaction` will trigger `shardingsphere-integration-test-suite` and `shardingsphere-integration-test-scaling`, but it's not necessary.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #19811: [CI] Improve GitHub Actions integration test

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #19811:
URL: https://github.com/apache/shardingsphere/pull/19811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org