You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by urbanenomad <gi...@git.apache.org> on 2016/04/29 11:56:25 UTC

[GitHub] camel pull request: Previous code was over writing result values

GitHub user urbanenomad opened a pull request:

    https://github.com/apache/camel/pull/970

    Previous code was over writing result values

    I apologize for my earlier faux pas.  I have properly tested this and verified that it passes the unit test.  I also took a more direct solution to this bug which was occurring due to multiple calls to the addToResult method which would overwrite the out message header with the in message header and would end up with just the result values of the last call to the addToResult.  I decided the best way to tackle this was to wrap updates into a map and pass that as a single call to a new method called addToResults which pretty much did what the previous code did but in a single method call.  The new method accepts a hashMap.  I have verified that it is properly returning all the result values to the next component in the message pipe.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/urbanenomad/camel camel-2.17.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/970.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #970
    
----
commit 66c9863f5fdd5385b6290c97c2222c4c01ec342d
Author: wkim <wk...@qualcomm.com>
Date:   2016-04-29T09:41:58Z

    Previous code was over writing result values after each call to addToResult call

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] camel pull request: Previous code was over writing result values

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/camel/pull/970


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---