You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/10 15:07:28 UTC

[GitHub] [commons-bcel] garydgregory commented on pull request #58: BCEL-341: Oak class file patch

garydgregory commented on pull request #58:
URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671412245


   -1 for now:
   - Fails the build due to a checkstyle error: https://travis-ci.org/github/apache/commons-bcel/jobs/716255992
   - No unit tests. One or more unit tests should fail without the patch to the main folder.
   - The implementation feels at first glance like a class file version specific brute force hack using conditionals and booleans, as opposed to a more object oriented solution. Needs more study on my side as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org