[GitHub] [apisix] moonming commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox <gi...@apache.org>]

moonming commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-675165303


   you can create a discuss thread in mailinglist for this issue, which is a
   big change.
   
   Shuyang Wu <no...@github.com> 于 2020年8月17日周一 下午6:38写道：
   
   > *@Yiyiyimu* commented on this pull request.
   > ------------------------------
   >
   > In apisix/core.lua
   > <https://github.com/apache/apisix/pull/2036#discussion_r471392464>:
   >
   > > @@ -19,7 +19,9 @@ local local_conf = require("apisix.core.config_local").local_conf()
   >
   >  local config_center = local_conf.apisix and local_conf.apisix.config_center
   >                        or "etcd"
   > +local etcd_version = local_conf.etcd.version == "v3" and "_v3" or ""
   >
   > Currently, the implementation is to use v2 as the default, and user would
   > change to v3 if needed. Of course we can use v3 as default.
   >
   > ping @nic-chen <https://github.com/nic-chen> @membphis
   > <https://github.com/membphis> maybe we need to discuss about it
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix/pull/2036#discussion_r471392464>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK3MOR6XOWTTQEQIPL3SBECDZANCNFSM4P2AS3KQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org