You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/10/29 20:52:19 UTC

svn commit: r1845172 - /pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java

Author: tilman
Date: Mon Oct 29 20:52:19 2018
New Revision: 1845172

URL: http://svn.apache.org/viewvc?rev=1845172&view=rev
Log:
PDFBOX-4071: simplify code + avoid memory leak

Modified:
    pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java

Modified: pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java?rev=1845172&r1=1845171&r2=1845172&view=diff
==============================================================================
--- pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java (original)
+++ pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java Mon Oct 29 20:52:19 2018
@@ -40,6 +40,7 @@ import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.cos.COSStream;
 import org.apache.pdfbox.cos.COSUpdateInfo;
 import org.apache.pdfbox.examples.signature.validation.CertInformationCollector.CertSignatureInformation;
+import org.apache.pdfbox.io.IOUtils;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.PDDocumentCatalog;
 import org.bouncycastle.cert.ocsp.BasicOCSPResp;
@@ -415,13 +416,16 @@ public class AddValidationInformation
     private COSStream writeDataToStream(byte[] data) throws IOException
     {
         COSStream stream = document.getDocument().createCOSStream();
-        COSArray filters = new COSArray();
-        filters.add(COSName.FLATE_DECODE);
-
-        OutputStream os = stream.createOutputStream(filters);
-        os.write(data);
-        os.close();
-
+        OutputStream os = null;
+        try
+        {
+            os = stream.createOutputStream(COSName.FLATE_DECODE);
+            os.write(data);
+        }
+        finally
+        {
+            IOUtils.closeQuietly(os);
+        }
         return stream;
     }
 
@@ -449,6 +453,7 @@ public class AddValidationInformation
 
     public static void main(String[] args) throws IOException, GeneralSecurityException
     {
+args = new String[]{"C:\\Users\\Tilman\\Downloads\\ebox_certified_eutl.pdf"};
         if (args.length != 1)
         {
             usage();