You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Hugo Palma (JIRA)" <de...@tapestry.apache.org> on 2008/02/07 14:06:20 UTC

[jira] Created: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Wrong behaviour when component name ends with the parent package name
---------------------------------------------------------------------

                 Key: TAPESTRY-2133
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
             Project: Tapestry
          Issue Type: Bug
          Components: Framework
    Affects Versions: 5.0.9
            Reporter: Hugo Palma


If i have a component layout/MyLayout Tapestry only sees the name layout/My.
The rule seems to be that if the component name ends with the path name then the path is removed from the component name.

This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Hugo Palma (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566705#action_12566705 ] 

Hugo Palma commented on TAPESTRY-2133:
--------------------------------------

I agree with Kevin.

If both forms could be accepted we could have the benefits of automatic url shortening without the confusion of getting component not found errors.

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Hugo Palma (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566646#action_12566646 ] 

Hugo Palma commented on TAPESTRY-2133:
--------------------------------------

I didn't notice this documented feature.

I'm not sure i agree with this, i think it will cause a lot of confusion. If i declare the component/page to have a given name then i want to reference it as such.
If i want shorter names i should just rename the component/page. Doing this for the user behind the curtains certainly confused me and i'm guessing will confuse more people.

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566722#action_12566722 ] 

Howard M. Lewis Ship commented on TAPESTRY-2133:
------------------------------------------------

Making both forms accepted sounds reasonable to me, and is pretty easy to implement.

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Hugo Palma (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hugo Palma updated TAPESTRY-2133:
---------------------------------

    Issue Type: Improvement  (was: Bug)

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Hugo Palma (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566576#action_12566576 ] 

Hugo Palma commented on TAPESTRY-2133:
--------------------------------------

This also happens with library names.
So if my library is called "myLibrary" the component ComponentMyLibrary will be seen by Tapestry as "myLibrary/Component" instead of the correct "myLibrary/ComponentMyLibrary".

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-2133.
------------------------------------------

    Resolution: Duplicate
      Assignee: Howard M. Lewis Ship

Duplicate of TAPESTRY-2149.

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>            Assignee: Howard M. Lewis Ship
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566635#action_12566635 ] 

Howard M. Lewis Ship commented on TAPESTRY-2133:
------------------------------------------------

None of this is a bug.  This is Tapestry stripping off the redundant parts of the component name, exactly as documented.  This is less important for component types than it is for page names (because the "stripped" or logical name is what goes into the URL, and we want that to be short and readable).

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Kevin Menard (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566676#action_12566676 ] 

Kevin Menard commented on TAPESTRY-2133:
----------------------------------------

I think the core issue is that both should be accepted.  I love the fact that Tapestry shortens my URLs for me.  However, I have been tripped up more than once specifying the full page name and not working out the stripping logic in my head.  So, if Tapestry could accept the long form and shorten it automatically (the logic already exists), this class of problems goes away.  Of course, it does introduce another, which is that the user may have a page that repeats the package info and then the shorten VS long search becomes ambiguous.  In reality, I see this happening far less frequently (ever?) than someone typing the full page name, especially as we look to have users moving from T4, where you need to type the full name, to T5, where you need to work out the shorten page logic.

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2133) Wrong behaviour when component name ends with the parent package name

Posted by "Kevin Menard (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566678#action_12566678 ] 

Kevin Menard commented on TAPESTRY-2133:
----------------------------------------

An added benefit of doing what I'm suggesting is that IDEs can refactor much better.  IDEA, at the very least, will search non-Java files for String instances, so changing a fully specified page name would update any templates that reference it as well.

> Wrong behaviour when component name ends with the parent package name
> ---------------------------------------------------------------------
>
>                 Key: TAPESTRY-2133
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2133
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 5.0.9
>            Reporter: Hugo Palma
>
> If i have a component layout/MyLayout Tapestry only sees the name layout/My.
> The rule seems to be that if the component name ends with the path name then the path is removed from the component name.
> This didn't happen in previous releases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org