You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/16 01:43:44 UTC

[GitHub] [cordova-docs] breautek opened a new pull request #1009: App Bundle Documentation

breautek opened a new pull request #1009: App Bundle Documentation
URL: https://github.com/apache/cordova-docs/pull/1009
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   This PR is a brother PR of https://github.com/apache/cordova-android/pull/764 that adds documentation related to the new app bundle feature.
   
   
   
   ### Description
   Documented the new acceptable key in `build.json` or via command line, `--packageType`, which accepts a value of `apk` or `bundle`. Defaults to `apk`.
   
   
   
   ### Testing
   I ran `npm serve` to generate the website, and observed my changes locally.
   I also ran `npm test`, which builds successfully with "Possible 404 in ToC warnings. The warnings however appears in master and because they are warnings I did ignore them.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org