You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2019/05/08 08:24:31 UTC

[wicket] branch WICKET-6662 updated: Code improvmentsfor #356

This is an automated email from the ASF dual-hosted git repository.

adelbene pushed a commit to branch WICKET-6662
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/WICKET-6662 by this push:
     new 755ecdd  Code improvmentsfor #356
755ecdd is described below

commit 755ecdd39d812a22a786fc963c2b13e8fb37bda3
Author: Andrea Del Bene <an...@gmail.com>
AuthorDate: Wed May 8 10:23:25 2019 +0200

    Code improvmentsfor #356
---
 .../java/org/apache/wicket/request/resource/DynamicImageResource.java   | 1 -
 .../test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java    | 2 +-
 .../src/main/java/org/apache/wicket/util/string/StringValue.java        | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java b/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java
index 8eeb845..468a498 100644
--- a/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java
+++ b/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java
@@ -19,7 +19,6 @@ package org.apache.wicket.request.resource;
 import java.awt.image.BufferedImage;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
-import java.sql.Time;
 import java.time.Instant;
 import javax.imageio.ImageIO;
 import javax.servlet.http.HttpServletResponse;
diff --git a/wicket-core/src/test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java b/wicket-core/src/test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java
index db87ddb..70b393e 100644
--- a/wicket-core/src/test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/page/PageAccessSynchronizerTest.java
@@ -106,7 +106,7 @@ class PageAccessSynchronizerTest
 		T2 t2 = new T2();
 		t2.setName("t2");
 		t1.start();
-		Thread.sleep(100);
+		TimeUnit.MILLISECONDS.sleep(100);
 		t2.start();
 
 		t1.join();
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java b/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
index bb5cc86..9e696db 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
@@ -558,7 +558,7 @@ public class StringValue implements IClusterable
 		}
 		catch (Exception e)
 		{
-			throw new StringValueConversionException("xxx", e);
+			throw new StringValueConversionException("Unable to convert '" + text + "' to a Duration value", e);
 		}
 	}