[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #680: GEODE-8666: Enforce no-non-virtual-dtor

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #680:
URL: https://github.com/apache/geode-native/pull/680#discussion_r513209098



##########
File path: cppcache/include/geode/CqQuery.hpp
##########
@@ -53,6 +53,8 @@ class Query;
  */
 class APACHE_GEODE_EXPORT CqQuery {
  public:
+  virtual ~CqQuery() = default;

Review comment:
       This will for sure change the ABI. I am not sure we can do this on the public headers until the next major.

##########
File path: cppcache/include/geode/AuthenticatedView.hpp
##########
@@ -90,7 +90,7 @@ class APACHE_GEODE_EXPORT AuthenticatedView : public RegionService {
   /**
    * @brief destructor
    */
-  virtual ~AuthenticatedView();
+  virtual ~AuthenticatedView() override;

Review comment:
       `virtual` is redundant when `override` is specified. Under some analyzers it will warn or error about it.

##########
File path: cppcache/include/geode/AuthenticatedView.hpp
##########
@@ -90,7 +90,7 @@ class APACHE_GEODE_EXPORT AuthenticatedView : public RegionService {
   /**
    * @brief destructor
    */
-  virtual ~AuthenticatedView();
+  virtual ~AuthenticatedView() override;

Review comment:
       Given that this is a public header, what impact is there to the ABI?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org