You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "Tchoupinax (via GitHub)" <gi...@apache.org> on 2026/10/24 10:51:12 UTC
[PR] fix(docker): drop baked-in wildcard listener defaults so the image boots [iggy]
Tchoupinax opened a new pull request, #4635:
URL: https://github.com/apache/iggy/pull/4635
## Problem
A bare `docker run apache/iggy` fails to boot with:
```
CONFIG - tcp.address binds the wildcard 0.0.0.0:8090, which says which interfaces this node accepts on rather than where a client reaches it, so cluster metadata would carry no address for this node. Set node.advertised_address to the address clients dial, or bind a concrete address.
Error: Config(InvalidConfigurationValue)
```
The `Dockerfile` baked in wildcard binds for every transport (`ENV IGGY_TCP_ADDRESS=0.0.0.0:8090`, plus http/quic/websocket). The shipped `core/server/config.toml` has `cluster.enabled = false`, and in that mode `ServerConfig::validate_client_facing_address_in_env` rejects a wildcard bind when `node.advertised_address` is unset: an unspecified bind names no address a client can dial.
This also contradicts the README, which states the published image "listens on `127.0.0.1` inside the container, so the host can't reach it by default."
## Fix
Remove the wildcard `ENV` overrides so the image uses the loopback defaults from `config.toml` and boots out of the box, matching the README. A short comment documents how to opt into reachability.
## Why this is safe
Every path that needs external reachability already pairs the wildcard bind with `IGGY_NODE_ADVERTISED_ADDRESS`:
- `web/docker-compose.yml`
- `.devcontainer/devcontainer.json`
- root `docker-compose.yml`
- `gateways/kafka/docker-compose.yml`
- `bdd/docker-compose.server.yml`
- both README `docker run` examples
None rely on the image's baked-in wildcard defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: drop baked-in wildcard listener defaults so the image boots [iggy]
Posted by "hubcio (via GitHub) via commits" <co...@iggy.apache.org>.
hubcio commented on code in PR #4635:
URL: https://github.com/apache/iggy/pull/4635#discussion_r4442030929
##########
Dockerfile:
##########
@@ -42,9 +42,13 @@ RUN apt-get update && apt-get install -y \
COPY --from=builder /build/target/release/iggy .
COPY --from=builder /build/target/release/iggy-server .
-ENV IGGY_HTTP_ADDRESS=0.0.0.0:3000
-ENV IGGY_QUIC_ADDRESS=0.0.0.0:8080
-ENV IGGY_TCP_ADDRESS=0.0.0.0:8090
-ENV IGGY_WEBSOCKET_ADDRESS=0.0.0.0:8092
+# Listeners default to the loopback addresses from the shipped config.toml, so a
Review Comment:
critical: root `docker-compose.yml` builds this file and sets only `IGGY_NODE_ADVERTISED_ADDRESS`, so without the wildcard binds the server runs but the host can't reach it. keep the four `ENV` lines, add `ENV IGGY_NODE_ADVERTISED_ADDRESS=localhost` below them and drop this comment block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: drop baked-in wildcard listener defaults so the image boots [iggy]
Posted by "Tchoupinax (via GitHub)" <gi...@apache.org>.
Tchoupinax commented on PR #4635:
URL: https://github.com/apache/iggy/pull/4635#issuecomment-6463431214
Hey @justinmclean,
thanks it is done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: set a default advertised address for the local Docker image [iggy]
Posted by "hubcio (via GitHub) via commits" <co...@iggy.apache.org>.
hubcio merged PR #4635:
URL: https://github.com/apache/iggy/pull/4635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(docker): drop baked-in wildcard listener defaults so the image boots [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4635:
URL: https://github.com/apache/iggy/pull/4635#issuecomment-6383314287
<!-- iggy-pr-triage-welcome -->
Thanks for the PR. It is labeled `S-waiting-on-review` and queued for review.
If AI was used to create this PR, you must run the [`team-review` skill](https://github.com/apache/iggy/blob/master/.claude/skills/team-review/SKILL.md) before opening it.
Slash commands (own line, regular comment) move it around the queue:
- `/ready` - back to `S-waiting-on-review` after addressing feedback
- `/author` - flip to `S-waiting-on-author` while you finish changes
- `/request-review @user-or-team` - request a reviewer
- `/pin` - exempt the PR from the stale bot, `/unpin` to undo
See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md#pr-triage-commands) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(docker): drop baked-in wildcard listener defaults so the image boots [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4635:
URL: https://github.com/apache/iggy/pull/4635#issuecomment-6383589498
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4635?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 90.76%. Comparing base ([`ce56aa1`](https://app.codecov.io/gh/apache/iggy/commit/ce56aa13039657aaa7534e3e5a4d1f0142911ab7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4f2f176`](https://app.codecov.io/gh/apache/iggy/commit/4f2f1769a0db9a04e16bf92fd8d520612cbb11b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4635 +/- ##
=========================================
Coverage 90.75% 90.76%
Complexity 2966 2966
=========================================
Files 1459 1459
Lines 347699 347696 -3
Branches 292547 292544 -3
=========================================
+ Hits 315569 315571 +2
+ Misses 25515 25504 -11
- Partials 6615 6621 +6
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.08% <ø> (+<0.01%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.73% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.54% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.64% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.59% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.45% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.67% <ø> (ø)` | |
| [C++ SDK](https://app.codecov.io/gh/apache/iggy/pull/4635/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.45% <ø> (ø)` | |
[see 18 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(docker): drop baked-in wildcard listener defaults so the image boots [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #4635:
URL: https://github.com/apache/iggy/pull/4635#issuecomment-6453190862
Thanks for fixing this. The PR Title check fails because docker is not an allowed scope. Please change the title to start with ci: and the check will pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org