You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/06 16:27:06 UTC
[GitHub] [camel-website] AghaSaad04 opened a new pull request #170: Searched
result styling
AghaSaad04 opened a new pull request #170: Searched result styling
URL: https://github.com/apache/camel-website/pull/170
Signed-off-by: Agha Saad Fraz <ag...@gmail.com>
## Issues:
- Search results push the website's Navbar.
- Searched result div should be scrollable.
## Solution:
- I have fixed the overlapping issue of the navbar items and searched result fiv. I have also added scrollbar to searched result div.
## Before:
## After:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Nayananga commented on issue #170: Searched result
styling
Posted by GitBox <gi...@apache.org>.
Nayananga commented on issue #170: Searched result styling
URL: https://github.com/apache/camel-website/pull/170#issuecomment-596163554
@AghaSaad04 this is great, I didn't know adding scroll bar is possible with CSS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #170: Searched result
styling
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #170: Searched result styling
URL: https://github.com/apache/camel-website/pull/170#issuecomment-595866300
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-170/Preview/index.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #170: Searched result
styling
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #170: Searched result styling
URL: https://github.com/apache/camel-website/pull/170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #170: Searched result
styling
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #170: Searched result styling
URL: https://github.com/apache/camel-website/pull/170#issuecomment-596388019
I think we can merge this. Looking at other implementations of Algolia search UI, like the one on https://gohugo.io/, https://www.gatsbyjs.org/ or https://reactjs.org/ they do not feature scrollbars. What is done there is that the search results are limited to 5 hits (we have 10) and the presentation is tailored to that: the results are presented in wider form and there's more distinction between each result.
This is an improvement on what we currently have, I think we can do better than this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services