You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/08 01:22:52 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

HyukjinKwon opened a new pull request #31773:
URL: https://github.com/apache/spark/pull/31773


   ### What changes were proposed in this pull request?
   
   Currently Binder link at Spark 3.1.1 (https://mybinder.org/v2/gh/apache/spark/v3.1.1-rc3?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart.ipynb) shows  `v3.1.1-rc3` like:
   ![Screen Shot 2021-03-08 at 10 10 55 AM](https://user-images.githubusercontent.com/6477701/110262729-ecb70880-7ff7-11eb-92ba-f151d74985a6.png)
   
   After the fix, it will shows the explicit hash:
   
   ![Screen Shot 2021-03-08 at 10 17 25 AM](https://user-images.githubusercontent.com/6477701/110262740-f476ad00-7ff7-11eb-8632-5b418ff87024.png)
   
   Note that it is hash in order to make both dev and release easier.
   
   ### Why are the changes needed?
   
   To hide RC tags.
   
   ### Does this PR introduce _any_ user-facing change?
   
   It will just change the URL shown when Binder is being loaded.
   
   ### How was this patch tested?
   
   Manually tested:
   
   ```bash
   make clean html
   ```
   
   ![Screen Shot 2021-03-08 at 10 17 06 AM](https://user-images.githubusercontent.com/6477701/110262813-2ee04a00-7ff8-11eb-9983-c4484f7832c4.png)
   
   
   ```bash
   git_hash=`git rev-parse --short HEAD`
   export GIT_HASH=$git_hash
   make clean html
   ```
   
   ![Screen Shot 2021-03-08 at 10 17 25 AM](https://user-images.githubusercontent.com/6477701/110262805-2982ff80-7ff8-11eb-8560-e1e2aa7b263a.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792407784


   **[Test build #135850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135850/testReport)** for PR 31773 at commit [`9847fd1`](https://github.com/apache/spark/commit/9847fd1c7325b0434b0feca265c5d546fc27e490).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon removed a comment on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792400108


   @srowen, can you take a quick look please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792411417


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40432/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792466725


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135850/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792466725


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135850/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792406202


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792400937


   @srowen, can you take a quick look please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792411417


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40432/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792406133


   This requires a manual testing, and it wouldn't affect anything in the tests. It passed the Python linters (documentation build) too. I am just merging it in.
   
   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792407784


   **[Test build #135850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135850/testReport)** for PR 31773 at commit [`9847fd1`](https://github.com/apache/spark/commit/9847fd1c7325b0434b0feca265c5d546fc27e490).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792454416


   **[Test build #135850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135850/testReport)** for PR 31773 at commit [`9847fd1`](https://github.com/apache/spark/commit/9847fd1c7325b0434b0feca265c5d546fc27e490).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31773:
URL: https://github.com/apache/spark/pull/31773


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31773: [SPARK-34657][PYTHON][DOCS] Replace the tag of release to the hash to hide RC tags in Binder

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31773:
URL: https://github.com/apache/spark/pull/31773#issuecomment-792400108


   @srowen, can you take a quick look please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org