You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/12/03 02:53:02 UTC
Review Request 15955: Fixed a flaky test:
FaultToleranceTest.ReregisterFrameworkExitedExecutor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15955/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-846
https://issues.apache.org/jira/browse/MESOS-846
Repository: mesos-git
Description
-------
The timing in CI was such that the status update manager received the new master notification after holding a status update. This results in a flush() call which re-sends the update.
The fix here is to drop all status update messages instead.
Diffs
-----
src/tests/fault_tolerance_tests.cpp 27095cc7eedb910fdab9b247a98ce492b828d464
Diff: https://reviews.apache.org/r/15955/diff/
Testing
-------
$ sudo ./bin/mesos-tests.sh --gtest_filter="*ReregisterFrameworkExitedExecutor*" --verbose --gtest_repeat=250 --gtest_break_on_failure
Thanks,
Ben Mahler
Re: Review Request 15955: Fixed a flaky test:
FaultToleranceTest.ReregisterFrameworkExitedExecutor.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15955/#review29670
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 3, 2013, 1:53 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15955/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 1:53 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-846
> https://issues.apache.org/jira/browse/MESOS-846
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The timing in CI was such that the status update manager received the new master notification after holding a status update. This results in a flush() call which re-sends the update.
>
> The fix here is to drop all status update messages instead.
>
>
> Diffs
> -----
>
> src/tests/fault_tolerance_tests.cpp 27095cc7eedb910fdab9b247a98ce492b828d464
>
> Diff: https://reviews.apache.org/r/15955/diff/
>
>
> Testing
> -------
>
> $ sudo ./bin/mesos-tests.sh --gtest_filter="*ReregisterFrameworkExitedExecutor*" --verbose --gtest_repeat=250 --gtest_break_on_failure
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15955: Fixed a flaky test:
FaultToleranceTest.ReregisterFrameworkExitedExecutor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15955/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 1:53 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Bugs: MESOS-846
https://issues.apache.org/jira/browse/MESOS-846
Repository: mesos-git
Description
-------
The timing in CI was such that the status update manager received the new master notification after holding a status update. This results in a flush() call which re-sends the update.
The fix here is to drop all status update messages instead.
Diffs
-----
src/tests/fault_tolerance_tests.cpp 27095cc7eedb910fdab9b247a98ce492b828d464
Diff: https://reviews.apache.org/r/15955/diff/
Testing
-------
$ sudo ./bin/mesos-tests.sh --gtest_filter="*ReregisterFrameworkExitedExecutor*" --verbose --gtest_repeat=250 --gtest_break_on_failure
Thanks,
Ben Mahler