[jira] [Updated] (LUCENE-6488) HandleTrackingFs leaks files if #onClose throws an exception

["Simon Willnauer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-6488:
------------------------------------
    Attachment: LUCENE-6488.patch

here is a patch and a test that fails without the fix

> HandleTrackingFs leaks files if #onClose throws an exception
> ------------------------------------------------------------
>
>                 Key: LUCENE-6488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6488
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/test-framework
>    Affects Versions: 5.1
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: Trunk, 5.x, 5.2
>
>         Attachments: LUCENE-6488.patch
>
>
> if #onClose throws an exception for instance due to an error in #onOpen we leak the filehandle since we don't call super.close(). I ran into this in Elasticsearch tests where files are concurrently deleted and we got a WindowsFS -> LeakFS -> UnixFs. The UnixFS opened the file but by the time WindowsFS tried to read the files metadata it was already deleted causing onOpen to barf and we leaked the file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org