You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/14 00:31:54 UTC
[GitHub] [incubator-superset] mistercrunch opened a new issue #12027: style: padding/alignement in Data submenu
mistercrunch opened a new issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027
## Screenshot
<img width="584" alt="Screen Shot 2020-12-13 at 4 28 57 PM" src="https://user-images.githubusercontent.com/487433/102028713-59f03000-3d60-11eb-81d0-e640e78a7d71.png">
## Description
The padding/alignement in the submenu looks a bit off. I think to look right we'll have to:
- pills should be lower so that they align with the `Data` title on the lef
- padding above and under those pills should be identical / symetric
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-745627740
@geido ^^^ we would like to get to pixel perfect! thank you for taking it on!! 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai closed issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
nytai closed issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mihir174 edited a comment on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
mihir174 edited a comment on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-745621490
Yes, agreed. Alignment should look like this (ignore content)-
<img width="699" alt="Screen Shot 2020-12-15 at 3 03 04 PM" src="https://user-images.githubusercontent.com/64227069/102283147-a49bb480-3ee6-11eb-8d2a-268d65f5dccb.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-744098851
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.63. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-744151409
> * pills should be lower so that they align with the `Data` title on the lef
<img width="1585" alt="Screen Shot 2020-12-13 at 7 58 06 PM" src="https://user-images.githubusercontent.com/67837651/102039160-e8bf7580-3d7d-11eb-83e4-ff371619c1cd.png">
yea i think the pill should be lower and the nav item that should be aligned from the bottom with `Data` title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mihir174 commented on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
mihir174 commented on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-745625874
<img width="668" alt="Screen Shot 2020-12-15 at 3 14 17 PM" src="https://user-images.githubusercontent.com/64227069/102283940-3657f180-3ee8-11eb-8ad9-3b49153b6713.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-744151409
> * pills should be lower so that they align with the `Data` title on the lef
<img width="1585" alt="Screen Shot 2020-12-13 at 7 58 06 PM" src="https://user-images.githubusercontent.com/67837651/102039160-e8bf7580-3d7d-11eb-83e4-ff371619c1cd.png">
yea i think the pill should be lower and the nav items should be aligned from the bottom with `Data` title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mihir174 commented on issue #12027: style: padding/alignement in Data submenu
Posted by GitBox <gi...@apache.org>.
mihir174 commented on issue #12027:
URL: https://github.com/apache/incubator-superset/issues/12027#issuecomment-745621490
Yes, agreed. Should look like this-
<img width="699" alt="Screen Shot 2020-12-15 at 3 03 04 PM" src="https://user-images.githubusercontent.com/64227069/102283147-a49bb480-3ee6-11eb-8d2a-268d65f5dccb.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org