You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ning Zhang <nz...@fb.com> on 2011/04/12 00:34:37 UTC

Review Request: HIVE-2106. Increase the number of operator counter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/579/
-----------------------------------------------------------

Review request for hive.


Summary
-------

increase the number of operator counters from 400 to 1000.


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1090490 

Diff: https://reviews.apache.org/r/579/diff


Testing
-------


Thanks,

Ning


Re: Review Request: HIVE-2106. Increase the number of operator counter

Posted by Ning Zhang <nz...@fb.com>.

> On 2011-04-11 22:38:54, Carl Steinbach wrote:
> >

Carl, we are still using the Hadoop 0.17 API.  This patch is a short-term solution to fix current use cases.  We should eventually move to use the 0.20 API which doesn't require enum.


- Ning


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/579/#review425
-----------------------------------------------------------


On 2011-04-11 22:34:37, Ning Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/579/
> -----------------------------------------------------------
> 
> (Updated 2011-04-11 22:34:37)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> increase the number of operator counters from 400 to 1000.
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1090490 
> 
> Diff: https://reviews.apache.org/r/579/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ning
> 
>


Re: Review Request: HIVE-2106. Increase the number of operator counter

Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/579/#review425
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
<https://reviews.apache.org/r/579/#comment807>

    Is this comment still accurate? If so, can we remove this entirely since we no longer support 0.17?


- Carl


On 2011-04-11 22:34:37, Ning Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/579/
> -----------------------------------------------------------
> 
> (Updated 2011-04-11 22:34:37)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> increase the number of operator counters from 400 to 1000.
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1090490 
> 
> Diff: https://reviews.apache.org/r/579/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ning
> 
>