You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2023/01/16 13:07:00 UTC
[jira] [Closed] (FLINK-30350) Write dependency-reduced pom to default directory
[ https://issues.apache.org/jira/browse/FLINK-30350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-30350.
------------------------------------
Resolution: Fixed
master: 60101e120fb2bd2393e9da00f07e1d53cec35c23
> Write dependency-reduced pom to default directory
> -------------------------------------------------
>
> Key: FLINK-30350
> URL: https://issues.apache.org/jira/browse/FLINK-30350
> Project: Flink
> Issue Type: Technical Debt
> Components: Build System
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.17.0
>
>
> The dependency-reduced pom is currently written to the target/ directory. This makes sense in general as it is a generated artifact, and should be automatically cleaned-up when doing a mvn clean.
> The shade-plugin however marks this pom as the modules pom during the build, and maven has a requirement that the basedir of a module is where the pom resides.
> As a result the basedir is changed whenever dependency-reduction is applied, causing weird side-effects like changing the working directory during IT cases.
> Let's bite the bullet and keep the dependency-reduced pom next to the original pom, with some extra configuration to remove it during a mvn clean.
> This side-steps all the issues encountered in FLINK-30083.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)