You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/14 22:06:05 UTC

[GitHub] [trafficcontrol] ezelkow1 opened a new issue #5936: Add a glob blox + advanced/pcre box for invalidations

ezelkow1 opened a new issue #5936:
URL: https://github.com/apache/trafficcontrol/issues/5936


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/slack-invite)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  improvement request (usability, performance, tech debt, etc.)
   <!--(Please do not submit support requests here - see above)-->
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Traffic Portal
   
   ## Current behavior:
   <!-- Describe how the current features are insufficient. -->
   The current behavior is to only take a regex. This can be confusing for the average user who does not know regex syntax and usage. 
   
   ## New behavior:
   <!-- Describe how the feature would improve Traffic Control -->
   Most users are familiar with using globs which also account for the majority of invalidations. I believe defaulting to presenting a glob box (with then a supplemental/show-able advanced box that can take a real regex) would help with usability as well as more correct invalidation requests
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If you can illustrate your feature request better with an example, please
   provide the *STEPS TO REPRODUCE* and include the applicable TC version.
   If not, feel free to delete this section.
   -->
   
   ## Anything else:
   <!--
   e.g. additional context, related issues, suggestions about how to approach (feel
   free to delete this section)
   -->
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c commented on issue #5936: Add a glob blox + advanced/pcre box for invalidations

Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5936:
URL: https://github.com/apache/trafficcontrol/issues/5936#issuecomment-861028393


   Some notes: by "glob," we mean `*` as a wildcard. So, this will need to:
   1. escape all special characters in PCRE Regex with `\` (except `*`)
   2. then replace any `*` with the PCRE `.*`.
   
   Also, `*` is a valid URL character. So this will need to also allow users to use `**` to indicate a literal `*` in the URL. So:
   - the above replacing should _not_ replace `**` with `.*.*`, but rather with `\*`.
   - we should add a sentence to the UI explaining that.
   
   
   
   
   
   3:33
   Hm, * is valid in URL Path. So, maybe we need to make ** how people do literal *. Should be fine. And put a sentence saying that in the UI text.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c edited a comment on issue #5936: Add a glob blox + advanced/pcre box for invalidations

Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on issue #5936:
URL: https://github.com/apache/trafficcontrol/issues/5936#issuecomment-861028393


   Some notes: by "glob," we mean `*` as a wildcard. So, this will need to:
   1. escape all special characters in PCRE Regex with `\` (except `*`)
   2. then replace any `*` with the PCRE `.*`.
   
   Also, `*` is a valid URL character. So this will need to also allow users to use `**` to indicate a literal `*` in the URL. So:
   - the above replacing should _not_ replace `**` with `.*.*`, but rather with `\*`.
   - we should add a sentence to the UI explaining that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org