You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan J Baxter <rj...@us.ibm.com> on 2011/07/07 02:26:19 UTC
Call For Reviewers
Shindig Committers,
Our team has sent out several review requests on for some of the features
we have been working on for Shindig 3.0. (Most of which were demoed at
the OpenSocial state of the union for those that were apple to attend.)
Some requests have been out there for a few weeks and we have not received
any feedback. Some of these are not just simple changes so I would like
to get the review process started on them so we can begin to iterate on
the code as a team. Please see the code review requests below. (Sorry
for not using the apache code review tool, let me know if people would
prefer the apache tool and we can move the patches over there.) Thanks.
View Enhancements: http://codereview.appspot.com/4641058/
Action+Selection Features: http://codereview.appspot.com/4645056/
Embedded Experiences: http://codereview.appspot.com/4641058/ (This was
just posted today.)
Updates to language/pref handling in the common container code:
https://reviews.apache.org/r/1011/ (Minor Change)
gadget_holder.getIframeElement fails to return the iframe element when
pubsub-2 feature is in use: https://reviews.apache.org/r/983/ (Minor
Change)
-Ryan
Email: rjbaxter@us.ibm.com
Phone: 978-899-3041
developerWorks Profile
Re: Call For Reviewers
Posted by Ryan J Baxter <rj...@us.ibm.com>.
Yes that's correct Henry. We just wanted to have the updates spec changes
there incase anyone wanted to see the APIs in the spec as well.
-Ryan
Email: rjbaxter@us.ibm.com
Phone: 978-899-3041
developerWorks Profile
From: Henry Saputra <he...@gmail.com>
To: dev@shindig.apache.org,
Date: 07/07/2011 01:59 PM
Subject: Re: Call For Reviewers
Ryan,
The final patch set review for
Action+Selection Features: http://codereview.appspot.com/4645056/
is actually contain change for the OpenSocial spec changes instead of
Shindig.
Should we review the patch set2?
- Henry
On Wed, Jul 6, 2011 at 5:26 PM, Ryan J Baxter <rj...@us.ibm.com> wrote:
> Shindig Committers,
>
> Our team has sent out several review requests on for some of the
features
> we have been working on for Shindig 3.0. (Most of which were demoed at
> the OpenSocial state of the union for those that were apple to attend.)
> Some requests have been out there for a few weeks and we have not
received
> any feedback. Some of these are not just simple changes so I would like
> to get the review process started on them so we can begin to iterate on
> the code as a team. Please see the code review requests below. (Sorry
> for not using the apache code review tool, let me know if people would
> prefer the apache tool and we can move the patches over there.) Thanks.
>
> View Enhancements: http://codereview.appspot.com/4641058/
> Action+Selection Features: http://codereview.appspot.com/4645056/
> Embedded Experiences: http://codereview.appspot.com/4641058/ (This was
> just posted today.)
> Updates to language/pref handling in the common container code:
> https://reviews.apache.org/r/1011/ (Minor Change)
> gadget_holder.getIframeElement fails to return the iframe element when
> pubsub-2 feature is in use: https://reviews.apache.org/r/983/ (Minor
> Change)
>
> -Ryan
>
> Email: rjbaxter@us.ibm.com
> Phone: 978-899-3041
> developerWorks Profile
>
>
Re: Call For Reviewers
Posted by Henry Saputra <he...@gmail.com>.
Ryan,
The final patch set review for
Action+Selection Features: http://codereview.appspot.com/4645056/
is actually contain change for the OpenSocial spec changes instead of Shindig.
Should we review the patch set2?
- Henry
On Wed, Jul 6, 2011 at 5:26 PM, Ryan J Baxter <rj...@us.ibm.com> wrote:
> Shindig Committers,
>
> Our team has sent out several review requests on for some of the features
> we have been working on for Shindig 3.0. (Most of which were demoed at
> the OpenSocial state of the union for those that were apple to attend.)
> Some requests have been out there for a few weeks and we have not received
> any feedback. Some of these are not just simple changes so I would like
> to get the review process started on them so we can begin to iterate on
> the code as a team. Please see the code review requests below. (Sorry
> for not using the apache code review tool, let me know if people would
> prefer the apache tool and we can move the patches over there.) Thanks.
>
> View Enhancements: http://codereview.appspot.com/4641058/
> Action+Selection Features: http://codereview.appspot.com/4645056/
> Embedded Experiences: http://codereview.appspot.com/4641058/ (This was
> just posted today.)
> Updates to language/pref handling in the common container code:
> https://reviews.apache.org/r/1011/ (Minor Change)
> gadget_holder.getIframeElement fails to return the iframe element when
> pubsub-2 feature is in use: https://reviews.apache.org/r/983/ (Minor
> Change)
>
> -Ryan
>
> Email: rjbaxter@us.ibm.com
> Phone: 978-899-3041
> developerWorks Profile
>
>