[jira] [Commented] (FELIX-3659) [DS] Share the method objects among all the dependency managers and component managers for the same class

["David Jencks (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450433#comment-13450433 ] 

David Jencks commented on FELIX-3659:
-------------------------------------

I think ComponentMetadataTest and the validation for duplicate reference names is wrong.  The spec says names have to be unique or it's an error, so I think we should fail validation in this case.  A couple of tests had duplicate reference names and this no longer works.

spec 4.3 112.4.8: This name is local to the component and can be used to locate a bound service of this reference with one of the locateService methods of ComponentContext. Each reference element within the component must have a unique name. This name attribute is optional. The default value of this attribute is the value of the interface attribute of this element. If multiple reference elements in the component use the same interface name, then using the default value for this attribute will result in duplicate reference names. In this case, this attribute must be specified with a unique name for the reference to avoid an error.
                
> [DS] Share the method objects among all the dependency managers and component managers for the same class
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3659
>                 URL: https://issues.apache.org/jira/browse/FELIX-3659
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>             Fix For: scr-1.8.0
>
>
> If you have configuration-based components or a component factory, all the related component managers can share the activate/modify/deactivate/bind/updated/unbind methods since they are all from the same class.  This will at least reduce the size of debug logging as you only need to find the methods once :-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira