You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/02 15:43:44 UTC
[GitHub] [apisix] ysc972 opened a new pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
ysc972 opened a new pull request #4362:
URL: https://github.com/apache/apisix/pull/4362
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
fix apisix cannot workes on kylin v10 Chinese os
#4157
### Pre-submission checklist:
* [ x ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r646036513
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,4 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
Review comment:
@ysc972 we haven't provided a one-line method, but you could follow the actions step (for this is using npm to install `markdownlint-cli`) to test locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645555376
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
We need an official confirm for the FAQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645931881
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,4 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
Review comment:
I am sorry.I want to know if there is a way to let me know my mistakes like this blank in my native environment before I commit.Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644444370
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
# Configuration File - Nginx Server Configs
# This is a read-only file, do not try to modify it.
+user root;
Review comment:
This can be archived without modifying APISIX: https://github.com/apache/apisix/blob/master/docs/en/latest/customize-nginx-configuration.md
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Is this problem confirmed by the official kylin v10 developer?
We don't want to be in trouble for spreading incorrect message about their OS.
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Maybe we can submit a PR that supporting specifying the `user`, but don't mention a specific OS name as it's not confirmed by the official.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644424720
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
# Configuration File - Nginx Server Configs
# This is a read-only file, do not try to modify it.
+user root;
Review comment:
It's dangerous to use `root` to launch APISIX. Exposing this item to `config.yaml` so people can decide to use which user.
##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
disable_sync_configuration_during_start: false # safe exit. Remove this once the feature is stable
nginx_config: # config for render the template to generate nginx.conf
+ #user: "root" # specifies the execution user of worker process.
+ # the "user" directive makes sense only if the master process runs with super-user privileges.
+ # if you is not root user,the default is current user.
Review comment:
```suggestion
# if you're not root user,the default is current user.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#issuecomment-853268283
Hi @ysc972 thanks for your contribution! I think it would be better if you could
1. Disable the root access by default. Make it as a configuration field in `config-default.yaml` and add a comment on who should enable this
2. Also add an entry in maybe FAQ to inform people how to do with Chinese OS, since it people have larger chances to view this file when they got problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644466157
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Maybe we can submit a PR that supporting specifying the `user`, but don't mention a specific OS name as it's not confirmed by the official.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644456291
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
# Configuration File - Nginx Server Configs
# This is a read-only file, do not try to modify it.
+user root;
Review comment:
I have add a configuration field in `config-default.yaml`,and add `How to run APISIX on the Chinese OS` to FAQ.
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Officials don't know about this problem, it's just my adaptation to the kylin v10 OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645397149
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Need I submit a new PR or change FAQ file in this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645448468
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
But in the Chinese arm OS , if we do not change this config, the apisix cannot run . It will throw "require faild" error like issue #4157. So should we write something in the FAQ to tell someone who uses apisix in Chinese arm OS how to resolve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645052000
##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
disable_sync_configuration_during_start: false # safe exit. Remove this once the feature is stable
nginx_config: # config for render the template to generate nginx.conf
+ #user: "root" # specifies the execution user of worker process.
+ # the "user" directive makes sense only if the master process runs with super-user privileges.
+ # if you is not root user,the default is current user.
Review comment:
```suggestion
# if you is not root user, by default it would be the current user.
```
##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
disable_sync_configuration_during_start: false # safe exit. Remove this once the feature is stable
nginx_config: # config for render the template to generate nginx.conf
+ #user: "root" # specifies the execution user of worker process.
Review comment:
```suggestion
#user: "root" # specifies the execution user of the worker process.
```
##########
File path: docs/en/latest/FAQ.md
##########
@@ -502,3 +502,14 @@ $ acme.sh --renew --domain demo.domain
```
Blog https://juejin.cn/post/6965778290619449351 has detail setup.
+
+
+## How to run APISIX on the Chinese OS
+
+When the APISIX is run as the root user on the Chinese OS, the worker process of nginx is started as the nobody user by default. In the Chinese OS, luajit will have a ·`require` failure problem. You can start APISIX by adding the following configuration in `conf/conf-default.yaml` and executing `make run` as the root user.
Review comment:
```suggestion
When APISIX runs as the root user on Chinese OS, the worker process of Nginx is started as the nobody user by default. In Chinese OS, luajit will have a "require" failure problem. You can start APISIX by adding the following configuration to `conf/conf-default.yaml` and executing `make run` as the root user.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645928620
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,4 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
Review comment:
Please remove the blank line which causes the failure: https://github.com/apache/apisix/pull/4362/checks?check_run_id=2751014883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644424720
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
# Configuration File - Nginx Server Configs
# This is a read-only file, do not try to modify it.
+user root;
Review comment:
It's dangerous to use `root` to launch APISIX. Exposing this item to `config.yaml` so people can decide to use which user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645399311
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
I think we can remove the FAQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644462712
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Officials don't know about this problem, it's just my adaptation to the kylin v10 OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644456291
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
# Configuration File - Nginx Server Configs
# This is a read-only file, do not try to modify it.
+user root;
Review comment:
I have add a configuration field in `config-default.yaml`,and add `How to run APISIX on the Chinese OS` to FAQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645052000
##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
disable_sync_configuration_during_start: false # safe exit. Remove this once the feature is stable
nginx_config: # config for render the template to generate nginx.conf
+ #user: "root" # specifies the execution user of worker process.
+ # the "user" directive makes sense only if the master process runs with super-user privileges.
+ # if you is not root user,the default is current user.
Review comment:
```suggestion
# if you is not root user, by default it would be the current user.
```
##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
disable_sync_configuration_during_start: false # safe exit. Remove this once the feature is stable
nginx_config: # config for render the template to generate nginx.conf
+ #user: "root" # specifies the execution user of worker process.
Review comment:
```suggestion
#user: "root" # specifies the execution user of the worker process.
```
##########
File path: docs/en/latest/FAQ.md
##########
@@ -502,3 +502,14 @@ $ acme.sh --renew --domain demo.domain
```
Blog https://juejin.cn/post/6965778290619449351 has detail setup.
+
+
+## How to run APISIX on the Chinese OS
+
+When the APISIX is run as the root user on the Chinese OS, the worker process of nginx is started as the nobody user by default. In the Chinese OS, luajit will have a ·`require` failure problem. You can start APISIX by adding the following configuration in `conf/conf-default.yaml` and executing `make run` as the root user.
Review comment:
```suggestion
When APISIX runs as the root user on Chinese OS, the worker process of Nginx is started as the nobody user by default. In Chinese OS, luajit will have a "require" failure problem. You can start APISIX by adding the following configuration to `conf/conf-default.yaml` and executing `make run` as the root user.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r646050086
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,4 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
Review comment:
@Yiyiyimu Thank you . I wii try it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644444370
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -19,6 +19,8 @@ return [=[
# Configuration File - Nginx Server Configs
# This is a read-only file, do not try to modify it.
+user root;
Review comment:
This can be archived without modifying APISIX: https://github.com/apache/apisix/blob/master/docs/en/latest/customize-nginx-configuration.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4362:
URL: https://github.com/apache/apisix/pull/4362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ysc972 commented on a change in pull request #4362: feat: support customzing worker's user
Posted by GitBox <gi...@apache.org>.
ysc972 commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r645572682
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
I have removed this FAQ and committed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644695585
##########
File path: conf/config-default.yaml
##########
@@ -130,6 +130,9 @@ apisix:
disable_sync_configuration_during_start: false # safe exit. Remove this once the feature is stable
nginx_config: # config for render the template to generate nginx.conf
+ #user: "root" # specifies the execution user of worker process.
+ # the "user" directive makes sense only if the master process runs with super-user privileges.
+ # if you is not root user,the default is current user.
Review comment:
```suggestion
# if you're not root user,the default is current user.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4362: fix apisix cannot workes on kylin v10 Chinese os
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4362:
URL: https://github.com/apache/apisix/pull/4362#discussion_r644457940
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -501,3 +501,13 @@ $ acme.sh --renew --domain demo.domain
```
详细步骤，可以参考博客 https://juejin.cn/post/6965778290619449351
+
+## 如何在kylin v10 国产操作系统运行apisix
Review comment:
Is this problem confirmed by the official kylin v10 developer?
We don't want to be in trouble for spreading incorrect message about their OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org