You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "magicgoody (via GitHub)" <gi...@apache.org> on 2023/10/17 08:48:37 UTC

[PR] Disable comment trigger for Performance and Load Tests [beam]

magicgoody opened a new pull request, #29035:
URL: https://github.com/apache/beam/pull/29035

   Reference PR https://github.com/apache/beam/pull/28915/files issue_comment removed 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #29035:
URL: https://github.com/apache/beam/pull/29035#discussion_r1363902566


##########
.github/workflows/beam_PostCommit_Python_Arm.yml:
##########
@@ -18,8 +18,6 @@
 name: PostCommit Python Arm
 
 on:
-  issue_comment:

Review Comment:
   ARM tests do not have Jenkins counterpart 



##########
.github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml:
##########
@@ -20,8 +20,6 @@ on:
     tags: ['v*']
     branches: ['master', 'release-*']
     paths: ['it/google-cloud-platform/**','.github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml']
-  issue_comment:

Review Comment:
   these postcommit tests do not have jenkins counterpart, see https://github.com/apache/beam/issues/28426#issuecomment-1728293446



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on PR #29035:
URL: https://github.com/apache/beam/pull/29035#issuecomment-1768214759

   > > @Abacn Shall we disable comment trigger for Perf and Load tests only or for all workflows? Not sure if we actually need to disable it, but I see you started doing it here: #28915
   > 
   > Yes, for Perf and Load tests (and postcommits that have Jenkins counterpart). Until we replaced the comment trigger the precommit issue_comment triggered are kept because PR testing are most likely need them, and the number of precommit is tolerable for the queueing issue described in #28909
   
   Hello, thanks for checking
   I also removed such workflow trigger for 4 PostCommit jobs where part of Jenkins is not yet disabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on PR #29035:
URL: https://github.com/apache/beam/pull/29035#issuecomment-1766338771

   @Abacn Shall we disable comment trigger for Perf and Load tests only or for all workflows? Not sure if we actually need to disable it, but I see you did it here: https://github.com/apache/beam/pull/28915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #29035:
URL: https://github.com/apache/beam/pull/29035#issuecomment-1766553514

   > @Abacn Shall we disable comment trigger for Perf and Load tests only or for all workflows? Not sure if we actually need to disable it, but I see you started doing it here: #28915
   
   Yes, for Perf and Load tests (and postcommits that have Jenkins counterpart). Until we replaced the comment trigger the precommit issue_comment triggered are kept because PR testing are most likely need them, and the number of precommit is tolerable for the queueing issue described in #28909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29035:
URL: https://github.com/apache/beam/pull/29035#issuecomment-1767391198

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #29035:
URL: https://github.com/apache/beam/pull/29035


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #29035:
URL: https://github.com/apache/beam/pull/29035#issuecomment-1766557176

   Notice that the tests that this PR involves are mostly newly added workflows after #28915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Disable comment trigger for Performance and Load Tests [beam]

Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #29035:
URL: https://github.com/apache/beam/pull/29035#discussion_r1364740274


##########
.github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml:
##########
@@ -20,8 +20,6 @@ on:
     tags: ['v*']
     branches: ['master', 'release-*']
     paths: ['it/google-cloud-platform/**','.github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml']
-  issue_comment:

Review Comment:
   Thanks for sharing the link, reverted changes back



##########
.github/workflows/beam_PostCommit_Python_Arm.yml:
##########
@@ -18,8 +18,6 @@
 name: PostCommit Python Arm
 
 on:
-  issue_comment:

Review Comment:
   Reverted back



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org