[jira] Commented: (MAHOUT-127) Remove warnings

["Sean Owen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714477#action_12714477 ] 

Sean Owen commented on MAHOUT-127:
----------------------------------

- I like the changes you mentioned, like @SuppressWarnings

- I personally favor keeping in explicit widening casts to show the reader what is happening. It might avoid subtle integer-division bugs. However it is a small point of preference. While I am inclined to say, let's not change it, I would go along with a change if there is other support from committers

- (Although casting from char to int in String.indexOf() is a tad over the top. I can live with reversing that.)

- I personally do not like putting serialVersionUID in Serializable classes. The default serialization logic is never wrong; it just might falsely conclude two versions of a class are not serialization-compatible when they are. When you add serialVersionUID, you introduce a burden to update it when fields change. And if you fail to, you create a much worse problem -- two versions are deemed compatible when they are not. I think there is no value to serialVersionUID unless compatibility of serialized form is necessary across revisions of a class, and that does not seem to be the case here.



> Remove warnings 
> ----------------
>
>                 Key: MAHOUT-127
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-127
>             Project: Mahout
>          Issue Type: Bug
>            Reporter: Benson Margulies
>         Attachments: warnings.diff
>
>
> The patch I'm about to attach gets rid of all the current yellow triangles for Eclipse 3.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.