You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 08:23:43 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8890: ARROW-10796: [C++] Implement optimized RecordBatch sorting

pitrou commented on a change in pull request #8890:
URL: https://github.com/apache/arrow/pull/8890#discussion_r542191830



##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -834,6 +1355,10 @@ class TableRadixSorter {
 // Sort a table using a single sort and multiple-key comparisons.
 class MultipleKeyTableSorter : public TypeVisitor {
  private:
+  // TODO instead of resolving chunks for each column independently, we could
+  // split the table into RecordBatches and pay the cost of chunked indexing
+  // at the first column only.

Review comment:
       `TableBatchReader` can be used for that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org