[GitHub] [calcite] zabetak commented on a diff in pull request #3243: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on code in PR #3243:
URL: https://github.com/apache/calcite/pull/3243#discussion_r1222905230


##########
core/src/main/java/org/apache/calcite/plan/RelOptRule.java:
##########
@@ -614,7 +616,10 @@ public static RelNode convert(RelNode rel, RelTraitSet toTraits) {
    * @return a relational expression with the desired trait; never null
    */
   public static RelNode convert(RelNode rel, @Nullable RelTrait toTrait) {

Review Comment:
   Should we deprecate the old methods so that we avoid the problem from re-appearing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org