You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/27 21:51:36 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2935: [GOBBLIN-1094] Added documentation of High level consumer

sv2000 commented on a change in pull request #2935: [GOBBLIN-1094] Added documentation of High level consumer
URL: https://github.com/apache/incubator-gobblin/pull/2935#discussion_r399554773
 
 

 ##########
 File path: gobblin-docs/developer-guide/HighLevelConsumer.md
 ##########
 @@ -0,0 +1,67 @@
+
+
+Problem Statement
+=================
+
+Current Gobblin Kafka [`High Level Consumer`](https://github.com/apache/incubator-gobblin/blob/master/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java) uses Kafka Consumer (0.8) API which will soon not be supported at linkedin. The Re-design's primary goal is to replace old kafka consumer APIs like [`ConsumerConnector`](https://archive.apache.org/dist/kafka/0.8.2.2/scaladoc/index.html#kafka.consumer.ConsumerConnector) and [`MessageAndMetadata`](https://archive.apache.org/dist/kafka/0.8.2.2/scaladoc/index.html#kafka.message.MessageAndMetadata) with a consumer abstraction [`GobblinKafkaConsumerClient`](https://github.com/apache/incubator-gobblin/blob/master/gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/GobblinKafkaConsumerClient.java). 
 
 Review comment:
   I don't think we need to say "will soon not be supported at Linkedin". You can just say that Gobblin support for Kafka 0.8 will be deprecated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services