[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6574: scripts: parametrize systemvm, router restart

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #6574:
URL: https://github.com/apache/cloudstack/pull/6574#discussion_r947644106


##########
setup/bindir/cloud-sysvmadm.in:
##########
@@ -72,21 +76,36 @@ do
         ;;
   z)    zone=" AND data_center_id=""$OPTARG"
         inzone=" in zone id=""$OPTARG"
+        ;;
+  i)    vmids="$OPTARG"
+        withids=" with id=""$OPTARG"
+        ;;
+  j)    vmtable="$OPTARG"
   esac
 done
 
 
-
+prapare_ids_clause() {
+  if [[ ! -z "$vmidsclause" ]]; then
+    return

Review Comment:
   it looks line 89 to line 91 are not required.
   
   ideally to have option to upgrade VR with livepatch.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org