You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/18 06:55:37 UTC

[GitHub] [hudi] nsivabalan opened a new pull request, #6982: [HUDI-5045] Adding support to configure index type with integ tests

nsivabalan opened a new pull request, #6982:
URL: https://github.com/apache/hudi/pull/6982

   ### Change Logs
   
   - Added support to configure index type with integ tests. 
   - Added yaml to test bulk_insert followed by upsert. 
   
   ### Impact
   
   More test coverage. 
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1301053321

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286",
       "triggerID" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa6013749d75caa0b4fe2050b96f009c4071f629",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12734",
       "triggerID" : "aa6013749d75caa0b4fe2050b96f009c4071f629",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9569f9f9e92efb9fab971f8aafbddddb255de02 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286) 
   * aa6013749d75caa0b4fe2050b96f009c4071f629 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12734) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1281909093

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286",
       "triggerID" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9569f9f9e92efb9fab971f8aafbddddb255de02 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1301046881

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286",
       "triggerID" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa6013749d75caa0b4fe2050b96f009c4071f629",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aa6013749d75caa0b4fe2050b96f009c4071f629",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9569f9f9e92efb9fab971f8aafbddddb255de02 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286) 
   * aa6013749d75caa0b4fe2050b96f009c4071f629 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1281902561

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9569f9f9e92efb9fab971f8aafbddddb255de02 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1301241481

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286",
       "triggerID" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa6013749d75caa0b4fe2050b96f009c4071f629",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12734",
       "triggerID" : "aa6013749d75caa0b4fe2050b96f009c4071f629",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa6013749d75caa0b4fe2050b96f009c4071f629 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12734) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6982:
URL: https://github.com/apache/hudi/pull/6982#discussion_r1002273223


##########
hudi-integ-test/src/main/scala/org/apache/hudi/integ/testsuite/dag/nodes/SparkInsertNode.scala:
##########
@@ -70,6 +70,7 @@ class SparkInsertNode(dagNodeConfig: Config) extends DagNode[RDD[WriteStatus]] {
       .option(DataSourceWriteOptions.PRECOMBINE_FIELD.key(), "test_suite_source_ordering_field")
       .option(DataSourceWriteOptions.TABLE_NAME.key, context.getHoodieTestSuiteWriter.getCfg.targetTableName)
       .option(DataSourceWriteOptions.TABLE_TYPE.key, context.getHoodieTestSuiteWriter.getCfg.tableType)
+      .option("hoodie.index.type", context.getHoodieTestSuiteWriter.getCfg.indexType)

Review Comment:
   nit: could you use the constant variable instead of the scalar String ("hoodie.index.type") to reference the config name here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
yihua merged PR #6982:
URL: https://github.com/apache/hudi/pull/6982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1282205939

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286",
       "triggerID" : "d9569f9f9e92efb9fab971f8aafbddddb255de02",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9569f9f9e92efb9fab971f8aafbddddb255de02 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12286) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6982:
URL: https://github.com/apache/hudi/pull/6982#issuecomment-1301359595

   Integration tests pass.  The CI failure is due to flakiness in `hudi-sync-common` module.  Merging this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org