You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/03/29 11:54:15 UTC

Re: Review Request 58024: Add hashing support into agent for caches ; add topology and metadata cache

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58024/#review170383
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 29, 2017, 11:51 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58024/
> -----------------------------------------------------------
> 
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 29, 2017, 11:51 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-20620
>     https://issues.apache.org/jira/browse/AMBARI-20620
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Details about hashing can be found in the design doc
> <https://docs.google.com/a/hortonworks.com/document/d/1p4ZW4r_QYx-
> QSvQUbeK7BF4MF6v8rVPs6vD-JwDf4Mk/edit?usp=sharing>
> 
> Also we should making cache immutable so that in future we will be fool-proof
> of someone changing the cache dictionary in runtime. Resulting in redundant
> synchronization of caches between agent and server.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterCache.py d7ea08c 
>   ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 2c35018 
>   ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py PRE-CREATION 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 49bb3d5 
>   ambari-agent/src/main/python/ambari_agent/Utils.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58024/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>