You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2018/01/18 17:09:30 UTC

[13/17] flink git commit: [hotfix] [core] Fix checkstyle for 'flink-core' : 'org.apache.flink.configuration'

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/ConfigDocsCompletenessChecker.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/ConfigDocsCompletenessChecker.java b/flink-core/src/test/java/org/apache/flink/configuration/ConfigDocsCompletenessChecker.java
index 741a483..3db85e7 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/ConfigDocsCompletenessChecker.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/ConfigDocsCompletenessChecker.java
@@ -31,17 +31,17 @@ import java.lang.reflect.Modifier;
 public class ConfigDocsCompletenessChecker {
 
 	public static void main(String[] args) throws Exception {
-		
+
 		String configFileContents = FileUtils.readFileToString(new File("docs/setup/config.md"));
 		Field[] fields = ConfigConstants.class.getFields();
-		
+
 		for (Field field : fields) {
 			if (Modifier.isStatic(field.getModifiers()) && field.getType().equals(String.class) &&
-					!field.getName().startsWith("DEFAULT"))
-			{
+					!field.getName().startsWith("DEFAULT")) {
+
 				Object val = field.get(null);
-				if (!configFileContents.contains((String)val)) {
-					System.out.println("++++ "+val+" is not mentioned in the configuration file!!!");
+				if (!configFileContents.contains((String) val)) {
+					System.out.println("++++ " + val + " is not mentioned in the configuration file!!!");
 				}
 			}
 		}

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/ConfigOptionsDocGeneratorTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/ConfigOptionsDocGeneratorTest.java b/flink-core/src/test/java/org/apache/flink/configuration/ConfigOptionsDocGeneratorTest.java
index 04facf0..0959f15 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/ConfigOptionsDocGeneratorTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/ConfigOptionsDocGeneratorTest.java
@@ -15,15 +15,22 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.apache.flink.configuration;
 
-import java.util.HashMap;
-import java.util.List;
 import org.apache.flink.api.java.tuple.Tuple2;
+
 import org.junit.Test;
 
-import static org.junit.Assert.*;
+import java.util.HashMap;
+import java.util.List;
 
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Tests for the ConfigOptionsDocGenerator.
+ */
+@SuppressWarnings("unused")
 public class ConfigOptionsDocGeneratorTest {
 
 	static class TestConfigGroup {
@@ -67,8 +74,8 @@ public class ConfigOptionsDocGeneratorTest {
 	}
 
 	@ConfigGroups(groups = {
-			@ConfigGroup(name = "firstGroup", keyPrefix = "first"),
-			@ConfigGroup(name = "secondGroup", keyPrefix = "second")})
+	@ConfigGroup(name = "firstGroup", keyPrefix = "first"),
+	@ConfigGroup(name = "secondGroup", keyPrefix = "second")})
 	static class TestConfigMultipleSubGroup {
 		public static ConfigOption<Integer> firstOption = ConfigOptions
 			.key("first.option.a")
@@ -103,58 +110,58 @@ public class ConfigOptionsDocGeneratorTest {
 		}
 
 		assertEquals("<table class=\"table table-bordered\">" +
-		             "<thead>" +
-		             "<tr>" +
-		             "<th class=\"text-left\" style=\"width: 20%\">Key</th>" +
-		             "<th class=\"text-left\" style=\"width: 15%\">Default Value</th>" +
-		             "<th class=\"text-left\" style=\"width: 65%\">Description</th>" +
-		             "</tr>" +
-		             "</thead>" +
-		             "<tbody>" +
-		             "<tr>" +
-		             "<td><h5>first.option.a</h5></td>" +
-		             "<td>2</td>" +
-		             "<td>This is example description for the first option.</td>" +
-		             "</tr>" +
-		             "</tbody>" +
-		             "</table>", tablesConverted.get("firstGroup"));
+				"<thead>" +
+				"<tr>" +
+				"<th class=\"text-left\" style=\"width: 20%\">Key</th>" +
+				"<th class=\"text-left\" style=\"width: 15%\">Default Value</th>" +
+				"<th class=\"text-left\" style=\"width: 65%\">Description</th>" +
+				"</tr>" +
+				"</thead>" +
+				"<tbody>" +
+				"<tr>" +
+				"<td><h5>first.option.a</h5></td>" +
+				"<td>2</td>" +
+				"<td>This is example description for the first option.</td>" +
+				"</tr>" +
+				"</tbody>" +
+				"</table>", tablesConverted.get("firstGroup"));
 		assertEquals("<table class=\"table table-bordered\">" +
-		             "<thead>" +
-		             "<tr>" +
-		             "<th class=\"text-left\" style=\"width: 20%\">Key</th>" +
-		             "<th class=\"text-left\" style=\"width: 15%\">Default Value</th>" +
-		             "<th class=\"text-left\" style=\"width: 65%\">Description</th>" +
-		             "</tr>" +
-		             "</thead>" +
-		             "<tbody>" +
-		             "<tr>" +
-		             "<td><h5>second.option.a</h5></td>" +
-		             "<td>(none)</td>" +
-		             "<td>This is long example description for the second option.</td>" +
-		             "</tr>" +
-		             "</tbody>" +
-		             "</table>", tablesConverted.get("secondGroup"));
+				"<thead>" +
+				"<tr>" +
+				"<th class=\"text-left\" style=\"width: 20%\">Key</th>" +
+				"<th class=\"text-left\" style=\"width: 15%\">Default Value</th>" +
+				"<th class=\"text-left\" style=\"width: 65%\">Description</th>" +
+				"</tr>" +
+				"</thead>" +
+				"<tbody>" +
+				"<tr>" +
+				"<td><h5>second.option.a</h5></td>" +
+				"<td>(none)</td>" +
+				"<td>This is long example description for the second option.</td>" +
+				"</tr>" +
+				"</tbody>" +
+				"</table>", tablesConverted.get("secondGroup"));
 		assertEquals("<table class=\"table table-bordered\">" +
-		             "<thead>" +
-		             "<tr>" +
-		             "<th class=\"text-left\" style=\"width: 20%\">Key</th>" +
-		             "<th class=\"text-left\" style=\"width: 15%\">Default Value</th>" +
-		             "<th class=\"text-left\" style=\"width: 65%\">Description</th>" +
-		             "</tr>" +
-		             "</thead>" +
-		             "<tbody>" +
-		             "<tr>" +
-		             "<td><h5>fourth.option.a</h5></td>" +
-		             "<td>(none)</td>" +
-		             "<td>This is long example description for the fourth option.</td>" +
-		             "</tr>" +
-		             "<tr>" +
-		             "<td><h5>third.option.a</h5></td>" +
-		             "<td>2</td>" +
-		             "<td>This is example description for the third option.</td>" +
-		             "</tr>" +
-		             "</tbody>" +
-		             "</table>", tablesConverted.get("default"));
+				"<thead>" +
+				"<tr>" +
+				"<th class=\"text-left\" style=\"width: 20%\">Key</th>" +
+				"<th class=\"text-left\" style=\"width: 15%\">Default Value</th>" +
+				"<th class=\"text-left\" style=\"width: 65%\">Description</th>" +
+				"</tr>" +
+				"</thead>" +
+				"<tbody>" +
+				"<tr>" +
+				"<td><h5>fourth.option.a</h5></td>" +
+				"<td>(none)</td>" +
+				"<td>This is long example description for the fourth option.</td>" +
+				"</tr>" +
+				"<tr>" +
+				"<td><h5>third.option.a</h5></td>" +
+				"<td>2</td>" +
+				"<td>This is example description for the third option.</td>" +
+				"</tr>" +
+				"</tbody>" +
+				"</table>", tablesConverted.get("default"));
 	}
 
 }

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java b/flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java
index fa86fed..232c829 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java
@@ -18,17 +18,17 @@
 
 package org.apache.flink.configuration;
 
+import org.apache.flink.util.InstantiationUtil;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.Test;
+
 import static org.junit.Assert.assertArrayEquals;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
-import org.apache.flink.util.InstantiationUtil;
-import org.apache.flink.util.TestLogger;
-
-import org.junit.Test;
-
 /**
  * This class contains test for the configuration package. In particular, the serialization of {@link Configuration}
  * objects is tested.
@@ -52,9 +52,9 @@ public class ConfigurationTest extends TestLogger {
 			orig.setFloat("PI", 3.1415926f);
 			orig.setDouble("E", Math.E);
 			orig.setBoolean("shouldbetrue", true);
-			orig.setBytes("bytes sequence", new byte[] { 1, 2, 3, 4, 5 } );
+			orig.setBytes("bytes sequence", new byte[] { 1, 2, 3, 4, 5 });
 			orig.setClass("myclass", this.getClass());
-	
+
 			final Configuration copy = InstantiationUtil.createCopyWritable(orig);
 			assertEquals("myvalue", copy.getString("mykey", "null"));
 			assertEquals(100, copy.getInteger("mynumber", 0));
@@ -64,7 +64,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(true, copy.getBoolean("shouldbetrue", false));
 			assertArrayEquals(new byte[] { 1, 2, 3, 4, 5 }, copy.getBytes("bytes sequence", null));
 			assertEquals(getClass(), copy.getClass("myclass", null, getClass().getClassLoader()));
-			
+
 			assertEquals(orig, copy);
 			assertEquals(orig.keySet(), copy.keySet());
 			assertEquals(orig.hashCode(), copy.hashCode());
@@ -79,7 +79,7 @@ public class ConfigurationTest extends TestLogger {
 	public void testConversions() {
 		try {
 			Configuration pc = new Configuration();
-			
+
 			pc.setInteger("int", 5);
 			pc.setLong("long", 15);
 			pc.setLong("too_long", TOO_LONG);
@@ -91,7 +91,7 @@ public class ConfigurationTest extends TestLogger {
 			pc.setString("string", "42");
 			pc.setString("non_convertible_string", "bcdefg&&");
 			pc.setBoolean("boolean", true);
-			
+
 			// as integer
 			assertEquals(5, pc.getInteger("int", 0));
 			assertEquals(5L, pc.getLong("int", 0));
@@ -100,7 +100,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("int", true));
 			assertEquals("5", pc.getString("int", "0"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("int", EMPTY_BYTES));
-			
+
 			// as long
 			assertEquals(15, pc.getInteger("long", 0));
 			assertEquals(15L, pc.getLong("long", 0));
@@ -109,7 +109,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("long", true));
 			assertEquals("15", pc.getString("long", "0"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("long", EMPTY_BYTES));
-			
+
 			// as too long
 			assertEquals(0, pc.getInteger("too_long", 0));
 			assertEquals(TOO_LONG, pc.getLong("too_long", 0));
@@ -118,7 +118,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("too_long", true));
 			assertEquals(String.valueOf(TOO_LONG), pc.getString("too_long", "0"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("too_long", EMPTY_BYTES));
-			
+
 			// as float
 			assertEquals(0, pc.getInteger("float", 0));
 			assertEquals(0L, pc.getLong("float", 0));
@@ -127,7 +127,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("float", true));
 			assertTrue(pc.getString("float", "0").startsWith("2.145677"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("float", EMPTY_BYTES));
-			
+
 			// as double
 			assertEquals(0, pc.getInteger("double", 0));
 			assertEquals(0L, pc.getLong("double", 0));
@@ -163,7 +163,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("too_long_double", true));
 			assertEquals(String.valueOf(TOO_LONG_DOUBLE), pc.getString("too_long_double", "0"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("too_long_double", EMPTY_BYTES));
-			
+
 			// as string
 			assertEquals(42, pc.getInteger("string", 0));
 			assertEquals(42L, pc.getLong("string", 0));
@@ -172,7 +172,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("string", true));
 			assertEquals("42", pc.getString("string", "0"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("string", EMPTY_BYTES));
-			
+
 			// as non convertible string
 			assertEquals(0, pc.getInteger("non_convertible_string", 0));
 			assertEquals(0L, pc.getLong("non_convertible_string", 0));
@@ -181,7 +181,7 @@ public class ConfigurationTest extends TestLogger {
 			assertEquals(false, pc.getBoolean("non_convertible_string", true));
 			assertEquals("bcdefg&&", pc.getString("non_convertible_string", "0"));
 			assertArrayEquals(EMPTY_BYTES, pc.getBytes("non_convertible_string", EMPTY_BYTES));
-			
+
 			// as boolean
 			assertEquals(0, pc.getInteger("boolean", 0));
 			assertEquals(0L, pc.getLong("boolean", 0));
@@ -201,13 +201,13 @@ public class ConfigurationTest extends TestLogger {
 	public void testCopyConstructor() {
 		try {
 			final String key = "theKey";
-			
+
 			Configuration cfg1 = new Configuration();
 			cfg1.setString(key, "value");
-			
+
 			Configuration cfg2 = new Configuration(cfg1);
 			cfg2.setString(key, "another value");
-			
+
 			assertEquals("value", cfg1.getString(key, ""));
 		}
 		catch (Exception e) {

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java b/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
index 9298a14..cd201f1 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
@@ -16,7 +16,6 @@
  * limitations under the License.
  */
 
-
 package org.apache.flink.configuration;
 
 import org.junit.Test;
@@ -26,10 +25,12 @@ import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
 import java.util.Set;
 
-import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
-
+/**
+ * Tests for the {@link DelegatingConfiguration}.
+ */
 public class DelegatingConfigurationTest {
 
 	@Test
@@ -40,7 +41,7 @@ public class DelegatingConfigurationTest {
 		Method[] delegateMethods = DelegatingConfiguration.class.getDeclaredMethods();
 
 		for (Method configurationMethod : confMethods) {
-			if (!Modifier.isPublic(configurationMethod.getModifiers()) ) {
+			if (!Modifier.isPublic(configurationMethod.getModifiers())) {
 				continue;
 			}
 
@@ -67,11 +68,11 @@ public class DelegatingConfigurationTest {
 				}
 			}
 
-			assertTrue("Configuration method '" + configurationMethod.getName() + 
+			assertTrue("Configuration method '" + configurationMethod.getName() +
 					"' has not been wrapped correctly in DelegatingConfiguration wrapper", hasMethod);
 		}
 	}
-	
+
 	@Test
 	public void testDelegationConfigurationWithNullPrefix() {
 		Configuration backingConf = new Configuration();
@@ -98,7 +99,6 @@ public class DelegatingConfigurationTest {
 
 		DelegatingConfiguration configuration = new DelegatingConfiguration(backingConf, prefix);
 		Set<String> keySet = configuration.keySet();
-		
 
 		assertEquals(keySet.size(), 1);
 		assertEquals(keySet.iterator().next(), expectedKey);

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java b/flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java
index 1cbc8f2..05ff315 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java
@@ -37,6 +37,9 @@ import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
+/**
+ * Tests for the configuration of the default file system scheme.
+ */
 public class FilesystemSchemeConfigTest extends TestLogger {
 
 	@Rule

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java b/flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java
index 322e64d..c5d2e62 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java
@@ -18,8 +18,11 @@
 
 package org.apache.flink.configuration;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
 
 import java.io.File;
 import java.io.FileNotFoundException;
@@ -27,10 +30,8 @@ import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.UUID;
 
-import org.apache.flink.util.TestLogger;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 
 /**
  * This class contains tests for the global configuration (parsing configuration directory information).
@@ -112,7 +113,7 @@ public class GlobalConfigurationTest extends TestLogger {
 	public void testInvalidYamlFile() throws IOException {
 		final File confFile = tempFolder.newFile(GlobalConfiguration.FLINK_CONF_FILENAME);
 
-		try (PrintWriter pw = new PrintWriter(confFile);) {
+		try (PrintWriter pw = new PrintWriter(confFile)) {
 			pw.append("invalid");
 		}
 

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/MemorySizeTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/MemorySizeTest.java b/flink-core/src/test/java/org/apache/flink/configuration/MemorySizeTest.java
index 9df541e..3fbc58b 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/MemorySizeTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/MemorySizeTest.java
@@ -24,7 +24,9 @@ import org.junit.Test;
 
 import java.io.IOException;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
 /**
  * Tests for the {@link MemorySize} class.
  */

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/flink-core/src/test/java/org/apache/flink/configuration/UnmodifiableConfigurationTest.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/configuration/UnmodifiableConfigurationTest.java b/flink-core/src/test/java/org/apache/flink/configuration/UnmodifiableConfigurationTest.java
index 26e3d7a..8163c50 100644
--- a/flink-core/src/test/java/org/apache/flink/configuration/UnmodifiableConfigurationTest.java
+++ b/flink-core/src/test/java/org/apache/flink/configuration/UnmodifiableConfigurationTest.java
@@ -18,12 +18,8 @@
 
 package org.apache.flink.configuration;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
-
 import org.apache.flink.util.TestLogger;
+
 import org.junit.Test;
 
 import java.lang.reflect.InvocationTargetException;
@@ -31,12 +27,17 @@ import java.lang.reflect.Method;
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
 /**
  * This class verifies that the Unmodifiable Configuration class overrides all setter methods in
  * Configuration.
  */
 public class UnmodifiableConfigurationTest extends TestLogger {
-	
+
 	@Test
 	public void testOverrideAddMethods() {
 		try {
@@ -52,14 +53,14 @@ public class UnmodifiableConfigurationTest extends TestLogger {
 			fail(e.getMessage());
 		}
 	}
-	
+
 	@Test
 	public void testExceptionOnSet() {
 		try {
 			@SuppressWarnings("rawtypes")
 			final ConfigOption rawOption = ConfigOptions.key("testkey").defaultValue("value");
 
-			Map<Class<?>, Object> parameters = new HashMap<Class<?>, Object>();
+			Map<Class<?>, Object> parameters = new HashMap<>();
 			parameters.put(byte[].class, new byte[0]);
 			parameters.put(Class.class, Object.class);
 			parameters.put(int.class, 0);

http://git-wip-us.apache.org/repos/asf/flink/blob/1f9c2d97/tools/maven/suppressions-core.xml
----------------------------------------------------------------------
diff --git a/tools/maven/suppressions-core.xml b/tools/maven/suppressions-core.xml
index 9640815..7b0ccc7 100644
--- a/tools/maven/suppressions-core.xml
+++ b/tools/maven/suppressions-core.xml
@@ -104,14 +104,6 @@ under the License.
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
 
 	<suppress
-		files="(.*)configuration[/\\](.*)"
-		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-	<!--Only additional checks for test sources. Those checks were present in the "pre-strict" checkstyle but were not applied to test sources. We do not want to suppress them for sources directory-->
-	<suppress
-		files="(.*)test[/\\](.*)configuration[/\\](.*)"
-		checks="AvoidStarImport"/>
-
-	<suppress
 		files="(.*)core[/\\]io[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
 	<!--Only additional checks for test sources. Those checks were present in the "pre-strict" checkstyle but were not applied to test sources. We do not want to suppress them for sources directory-->