You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by mattunderscorechampion <gi...@git.apache.org> on 2014/11/11 11:37:03 UTC
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
GitHub user mattunderscorechampion opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/315
Added location definition attribute to location owner
Added the location definition as an attribute to the location owner. This is may be needed to fix brooklyncentral/clocker#57. There are a couple of alternatives to this either the location definition ID could be used instead of the entire location definition or the attribute could be added to the DockerInfrastructure in Clocker but I suspect that other LocationOwners will need to unregister the location definition when deleting the location.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pushtechnology/incubator-brooklyn removalOfLocationDefinitions2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 0a1e0651786106803c7ffc2ca340768a8c545e97
Author: Matt Champion <ma...@gmail.com>
Date: 2014-10-23T16:53:54Z
Added location definition attribute to location owner
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
Posted by mattunderscorechampion <gi...@git.apache.org>.
Github user mattunderscorechampion closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
Posted by mattunderscorechampion <gi...@git.apache.org>.
GitHub user mattunderscorechampion reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/315
Added location definition attribute to location owner
Added the location definition as an attribute to the location owner. This is may be needed to fix brooklyncentral/clocker#57. There are a couple of alternatives to this either the location definition ID could be used instead of the entire location definition or the attribute could be added to the DockerInfrastructure in Clocker but I suspect that other LocationOwners will need to unregister the location definition when deleting the location.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pushtechnology/incubator-brooklyn removalOfLocationDefinitions2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 0a1e0651786106803c7ffc2ca340768a8c545e97
Author: Matt Champion <ma...@gmail.com>
Date: 2014-10-23T16:53:54Z
Added location definition attribute to location owner
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
Posted by mattunderscorechampion <gi...@git.apache.org>.
Github user mattunderscorechampion commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/315#issuecomment-62530359
Apparent cause of failure
[incubator-brooklyn-pull-requests] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx26 -Xms256m -XX:MaxPermSize=512m -cp /home/jenkins/jenkins-slave/maven3-agent.jar:/home/jenkins/tools/maven/apache-maven-3.0.4/boot/plexus-classworlds-2.4.jar org.jvnet.hudson.maven3.agent.Maven3Main /home/jenkins/tools/maven/apache-maven-3.0.4 /x1/jenkins/jenkins-slave/slave.jar /home/jenkins/jenkins-slave/maven3-interceptor.jar /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 37905
Error occurred during initialization of VM
Incompatible minimum and maximum heap sizes specified
ERROR: Failed to launch Maven. Exit code = 1
Invalid configuration of Jenkins job
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/315#issuecomment-62592363
Looks good. Merging :frog:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added location definition attribu...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/315#issuecomment-62551173
LGTM. Thanks.
The build problem is an Apache misconfiguration caused last night, affecting all projects. https://issues.apache.org/jira/browse/INFRA-8606
I think we've fixed our config locally so if you close and reopen @mattunderscorechampion it will kick off a new build.
@grkvlt Any comments? I've no objections to this being merged, and I see there is a CLA covering Matt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---