You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Ken Howe <kh...@pivotal.io> on 2016/02/27 00:40:19 UTC
Review Request 44107: GEDOE-856: Unit tests for TinyMemoryBlock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44107/
-----------------------------------------------------------
Review request for geode, Darrel Schneider and Sai Boorlagadda.
Repository: geode
Description
-------
To give testing access to the class, the access modifier of
TinyMemoryBlock and it's constructor has been changed from private to protected.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java a716f144d4d248a346ebf10e6826888c482eef09
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/TinyMemoryBlockJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/44107/diff/
Testing
-------
Precheckin is in progress
Thanks,
Ken Howe
Re: Review Request 44107: GEDOE-856: Unit tests for TinyMemoryBlock
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44107/#review121011
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Feb. 26, 2016, 3:40 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44107/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 3:40 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> To give testing access to the class, the access modifier of
> TinyMemoryBlock and it's constructor has been changed from private to protected.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java a716f144d4d248a346ebf10e6826888c482eef09
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/TinyMemoryBlockJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44107/diff/
>
>
> Testing
> -------
>
> Precheckin is in progress
>
>
> Thanks,
>
> Ken Howe
>
>
Re: Review Request 44107: GEDOE-856: Unit tests for TinyMemoryBlock
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44107/#review121461
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On Feb. 26, 2016, 11:40 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44107/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 11:40 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> To give testing access to the class, the access modifier of
> TinyMemoryBlock and it's constructor has been changed from private to protected.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java a716f144d4d248a346ebf10e6826888c482eef09
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/TinyMemoryBlockJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44107/diff/
>
>
> Testing
> -------
>
> Precheckin is in progress
>
>
> Thanks,
>
> Ken Howe
>
>