[GitHub] [incubator-superset] jackyq2015 commented on issue #5941: Filter dashboard clicking on chart

[GitBox <gi...@apache.org>]

jackyq2015 commented on issue #5941: Filter dashboard clicking on chart
URL: https://github.com/apache/incubator-superset/issues/5941#issuecomment-562179784
 
 
   According to ChartRenderer.jsx, it provides BLANK callback to addFilter.
   ```
     // dashboard callbacks
     addFilter: PropTypes.func,
     onFilterMenuOpen: PropTypes.func,
     onFilterMenuClose: PropTypes.func,
   
     const defaultProps = {
     addFilter: () => BLANK,
     onFilterMenuOpen: () => BLANK,
     onFilterMenuClose: () => BLANK,
     initialValues: BLANK,
     setControlValue() {},
     triggerRender: false,
   };
   ```
    In order to achieve this, I think need to:
   
   1. Implement the addFilter callback to viz type. it will broadcast the filter to the dashboard level.
   2. Other charts on the dashboard will receive the change and reflect the filter by checking shouldComponentUpdate in the same renderer. 
   
   Not sure if it is enough though
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org