You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/05/27 15:08:06 UTC

[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #2344: docs(bindings/java): for BlockingOperator

tisonkun commented on code in PR #2344:
URL: https://github.com/apache/incubator-opendal/pull/2344#discussion_r1208030803


##########
bindings/java/src/main/java/org/apache/opendal/BlockingOperator.java:
##########
@@ -30,12 +44,12 @@ public void write(String fileName, String content) {
         write(nativeHandle, fileName, content);
     }
 
-    public String read(String s) {
-        return read(nativeHandle, s);
+    public String read(String fileName) {

Review Comment:
   I don't know. I tend to keep consistent with how OpenDAL names it. Do you think `path` a good idea? If so, let me update all occrances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org