You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/13 16:03:34 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4081: Add ByteArray constructors (#3879)
tustvold opened a new pull request, #4081:
URL: https://github.com/apache/arrow-rs/pull/4081
_Draft as builds on #4065_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #3879
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #4081: Add ByteArray constructors (#3879)
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #4081:
URL: https://github.com/apache/arrow-rs/pull/4081#discussion_r1170261696
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -60,6 +60,85 @@ impl<T: ByteArrayType> GenericByteArray<T> {
/// Data type of the array.
pub const DATA_TYPE: DataType = T::DATA_TYPE;
+ /// Create a new [`GenericByteArray`] from the provided parts, panicking on failure
+ ///
+ /// # Panics
+ ///
+ /// Panics if [`GenericByteArray::try_new`] returns an error
+ pub fn new(
+ offsets: OffsetBuffer<T::Offset>,
+ values: Buffer,
+ nulls: Option<NullBuffer>,
+ ) -> Self {
+ Self::try_new(offsets, values, nulls).unwrap()
+ }
+
+ /// Create a new [`GenericByteArray`] from the provided parts, returning an error on failure
+ ///
+ /// # Errors
+ ///
+ /// * `offsets.len() - 1 != nulls.len()`
+ /// * Any consecutive pair of `offsets` does not denote a valid slice of `values`
+ pub fn try_new(
+ offsets: OffsetBuffer<T::Offset>,
+ values: Buffer,
+ nulls: Option<NullBuffer>,
+ ) -> Result<Self, ArrowError> {
+ let len = offsets.len() - 1;
+ T::validate(&offsets, &values)?;
+
+ if let Some(n) = nulls.as_ref() {
+ if n.len() != len {
Review Comment:
Don't we need to also check the length of values buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4081: Add ByteArray constructors (#3879)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4081:
URL: https://github.com/apache/arrow-rs/pull/4081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4081: Add ByteArray constructors (#3879)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4081:
URL: https://github.com/apache/arrow-rs/pull/4081#discussion_r1171264410
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -60,6 +60,85 @@ impl<T: ByteArrayType> GenericByteArray<T> {
/// Data type of the array.
pub const DATA_TYPE: DataType = T::DATA_TYPE;
+ /// Create a new [`GenericByteArray`] from the provided parts, panicking on failure
+ ///
+ /// # Panics
+ ///
+ /// Panics if [`GenericByteArray::try_new`] returns an error
+ pub fn new(
+ offsets: OffsetBuffer<T::Offset>,
+ values: Buffer,
+ nulls: Option<NullBuffer>,
+ ) -> Self {
+ Self::try_new(offsets, values, nulls).unwrap()
+ }
+
+ /// Create a new [`GenericByteArray`] from the provided parts, returning an error on failure
+ ///
+ /// # Errors
+ ///
+ /// * `offsets.len() - 1 != nulls.len()`
+ /// * Any consecutive pair of `offsets` does not denote a valid slice of `values`
+ pub fn try_new(
+ offsets: OffsetBuffer<T::Offset>,
+ values: Buffer,
+ nulls: Option<NullBuffer>,
+ ) -> Result<Self, ArrowError> {
+ let len = offsets.len() - 1;
+ T::validate(&offsets, &values)?;
+
+ if let Some(n) = nulls.as_ref() {
+ if n.len() != len {
Review Comment:
This is covered by `T::validate`, will add a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4081: Add ByteArray constructors (#3879)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4081:
URL: https://github.com/apache/arrow-rs/pull/4081#discussion_r1171263822
##########
arrow-array/src/types.rs:
##########
@@ -1569,6 +1604,21 @@ impl<O: OffsetSizeTrait> ByteArrayType for GenericBinaryType<O> {
} else {
DataType::Binary
};
+
+ fn validate(
+ offsets: &OffsetBuffer<Self::Offset>,
+ values: &Buffer,
+ ) -> Result<(), ArrowError> {
+ // offsets are guaranteed to be monotonically increasing and non-empty
+ let max_offset = offsets.last().unwrap().as_usize();
+ if values.len() < max_offset {
+ return Err(ArrowError::InvalidArgumentError(format!(
+ "Maximum offset of {max_offset} is larger than values of length {}",
+ values.len()
Review Comment:
I think the phrasing before is grammatically more correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #4081: Add ByteArray constructors (#3879)
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #4081:
URL: https://github.com/apache/arrow-rs/pull/4081#discussion_r1170242829
##########
arrow-array/src/types.rs:
##########
@@ -1569,6 +1604,21 @@ impl<O: OffsetSizeTrait> ByteArrayType for GenericBinaryType<O> {
} else {
DataType::Binary
};
+
+ fn validate(
+ offsets: &OffsetBuffer<Self::Offset>,
+ values: &Buffer,
+ ) -> Result<(), ArrowError> {
+ // offsets are guaranteed to be monotonically increasing and non-empty
+ let max_offset = offsets.last().unwrap().as_usize();
+ if values.len() < max_offset {
+ return Err(ArrowError::InvalidArgumentError(format!(
+ "Maximum offset of {max_offset} is larger than values of length {}",
+ values.len()
Review Comment:
```suggestion
"Maximum offset of {max_offset} is larger than length of values {}",
values.len()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org