You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/23 13:49:22 UTC
[GitHub] [incubator-yunikorn-k8shim] manirajv06 opened a new pull request #234: YUNIKORN-520: Gang scheduling waits indefinitely for placeholder pod …
manirajv06 opened a new pull request #234:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/234
…allocation even where is no quota left in the queue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #234: YUNIKORN-520: Gang scheduling waits indefinitely for placeholder pod …
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #234:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #234: YUNIKORN-520: Gang scheduling waits indefinitely for placeholder pod …
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #234:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/234#issuecomment-784221997
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=h1) Report
> Merging [#234](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=desc) (a4a48b8) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.24%`.
> The diff coverage is `55.55%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 59.75% 60.00% +0.24%
==========================================
Files 35 35
Lines 3133 3135 +2
==========================================
+ Hits 1872 1881 +9
+ Misses 1180 1173 -7
Partials 81 81
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.19% <100.00%> (+1.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=footer). Last update [5dc97fa...a4a48b8](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org